Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance of determinant #1118

Merged
merged 1 commit into from
May 31, 2018
Merged

Conversation

ericman314
Copy link
Collaborator

@ericman314 ericman314 commented May 30, 2018

Uses the LU decomposition to calculate the determinant.

Also added a test to verify that determinants of sparse matrices are calculated correctly.

Addresses #908, although more improvements are certainly possible.

Copy link
Collaborator

@harrysarson harrysarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot comment on the maths for I do not really understand it, but otherwise the code looks good 💯

@josdejong josdejong changed the base branch from master to develop May 31, 2018 18:55
@josdejong
Copy link
Owner

Awesome 😎

@josdejong josdejong merged commit afdd1c3 into develop May 31, 2018
@josdejong josdejong deleted the determinant-lu-decomp branch May 31, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants