-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing require "zlib" in deb.rb makes big deb package creation fail with error #1739
Comments
lancerinf
added a commit
to lancerinf/fpm
that referenced
this issue
Dec 14, 2020
Hi! I've got the same error. I will monkey patch too in the meantime. |
Glad that this helped out someone! For completeness, the way I've monkey patched it is this:
|
This affected us too, hoping to see the PR merged. |
This was referenced Jan 4, 2021
Ditto, also affecting us on Debian Bullseye |
@jordansissel Any chance of this being merged please? |
gitlab-runner-bot
pushed a commit
to gitlabhq/gitlab-runner
that referenced
this issue
Oct 13, 2023
Version 1.10.2 of fpm has the following bug, which prevents it from building debs: jordansissel/fpm#1739 for example https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/5089983316#L169 Bumping the version to the latest fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've encountered an issue with the DEB target for a NodeJS application, converting from DIR.
We are packaging all the node_modules folder together with our application code, so the starting DIR is pretty huge.
FPM smartly tries using zlib to deflate our package, but fails hard with this output:
I've experimented monkey-patching a
require "zlib"
intohttps://github.com/jordansissel/fpm/blob/master/lib/fpm/package/deb.rb
and realized that after that, it does the job excellently.So I guess I'm opening this Issue, and proposing the solution and can have a PR up for that in a heartbeat.
Let me know what you think and if I can open a PR to fix it.
The text was updated successfully, but these errors were encountered: