Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package creation for MacOS #54

Closed
wants to merge 3 commits into from
Closed

Add package creation for MacOS #54

wants to merge 3 commits into from

Conversation

terjekv
Copy link
Member

@terjekv terjekv commented Dec 1, 2020

No description provided.

@kniec
Copy link

kniec commented Dec 3, 2020

AWS has mac1.metal instances now... :)

.github/workflows/build-client-packages.yml Outdated Show resolved Hide resolved
.github/workflows/build-client-packages.yml Outdated Show resolved Hide resolved
@boegel
Copy link
Contributor

boegel commented Jan 4, 2021

@bedroge Failing tests look unrelated to the changes in this PR?

@bedroge
Copy link
Collaborator

bedroge commented Jan 4, 2021

@boegel The Centos 8 failures/timeouts have been solved in #57.

But I don't understand the issue with build-linux-packages: fpm gave some weird error

/usr/local/bundle/gems/fpm-1.11.0/lib/fpm/package/deb.rb:495:in `block in output': uninitialized constant FPM::Package::Deb::Zlib (NameError)
171	from <internal:kernel>:90:in `tap'
172	from /usr/local/bundle/gems/fpm-1.11.0/lib/fpm/package/deb.rb:494:in `output'
173	from /usr/local/bundle/gems/fpm-1.11.0/lib/fpm/command.rb:487:in `execute'
174	from /usr/local/bundle/gems/clamp-1.0.1/lib/clamp/command.rb:68:in `run'
175	from /usr/local/bundle/gems/fpm-1.11.0/lib/fpm/command.rb:574:in `run'
176	from /usr/local/bundle/gems/clamp-1.0.1/lib/clamp/command.rb:133:in `run'
177	from /usr/local/bundle/gems/fpm-1.11.0/bin/fpm:7:in `<top (required)>'
178	from /usr/local/bundle/bin/fpm:23:in `load'
179	from /usr/local/bundle/bin/fpm:23:in `<main>'

This worked fine with the last commits... and it doesn't look like the fpm action has been changed in the meantime (fpm version is still the same too)....

@bedroge
Copy link
Collaborator

bedroge commented Jan 4, 2021

@bedroge
Copy link
Collaborator

bedroge commented Jan 7, 2021

The CI for building the packages has been fixed, see #64.
Rerunning the tests now...

A fix for the failing Centos 8 tests is included in this PR:
#57

@bedroge
Copy link
Collaborator

bedroge commented Jan 8, 2021

Hmm, I think this part was already included in #48, so I guess we can close this PR.

@bedroge
Copy link
Collaborator

bedroge commented Jan 8, 2021

See for instance this action (triggered by PR #57) for a macOS package:
https://github.com/EESSI/filesystem-layer/actions/runs/408367869
We can make a new release soon, so that we have a versioned package for macOS.

Closing this PR.

@bedroge bedroge closed this Jan 8, 2021
peterstol pushed a commit to peterstol/filesystem-layer that referenced this pull request Feb 18, 2021
Update bootstrap script and use latest snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants