Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.1 Scheduled Tasks] Missing constants and demo plugin description #2196

Closed
jgerman-bot opened this issue Dec 31, 2021 · 1 comment
Closed

[4.1 Scheduled Tasks] Missing constants and demo plugin description #2196

jgerman-bot opened this issue Dec 31, 2021 · 1 comment
Assignees
@tecpromotion
Labels
core language change Joomla! 4.x
Milestone
4.1.0.v1

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#36479 Here are the upstream changes:

Click to expand the diff! 
diff --git a/administrator/language/en-GB/com_scheduler.sys.ini b/administrator/language/en-GB/com_scheduler.sys.ini
index 5206075a717b..90477b1ddde7 100644
--- a/administrator/language/en-GB/com_scheduler.sys.ini
+++ b/administrator/language/en-GB/com_scheduler.sys.ini
@@ -11,4 +11,6 @@ COM_SCHEDULER_MANAGER_TASK_EDIT="Edit Task"
 COM_SCHEDULER_MANAGER_TASK_NEW="New Task"
 COM_SCHEDULER_MANAGER_TASKS="Tasks Manager"
 COM_SCHEDULER_MSG_MANAGE_NO_TASK_PLUGINS="There are no task types matching your query."
+COM_SCHEDULER_TASKS_VIEW_DEFAULT_DESC="Schedule and Manage Task Routines."
+COM_SCHEDULER_TASKS_VIEW_DEFAULT_TITLE="Scheduled Tasks"
 COM_SCHEDULER_XML_DESCRIPTION="Component for managing scheduled tasks and cronjobs (if supported by the server)."
diff --git a/plugins/task/demotasks/demotasks.xml b/plugins/task/demotasks/demotasks.xml
index 25ec1ec22efb..fbd65e50e640 100644
--- a/plugins/task/demotasks/demotasks.xml
+++ b/plugins/task/demotasks/demotasks.xml
@@ -8,7 +8,7 @@
 	<authorEmail>[email protected]</authorEmail>
 	<authorUrl>www.joomla.org</authorUrl>
 	<version>4.1</version>
-	<description>Demo task routines for com_scheduler</description>
+	<description>PLG_TASK_DEMO_TASKS_XML_DESCRIPTION</description>
 	<files>
 		<filename plugin="demotasks">demotasks.php</filename>
 		<folder>language</folder>
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Jan 5, 2022
@tecpromotion
fix joomlagerman#2196
cce56d3
@tecpromotion tecpromotion added this to the 4.1.0.v1 milestone Jan 5, 2022
@tecpromotion
Copy link
Member

fixed with PR #2166

zero-24 added a commit that referenced this issue Jan 15, 2022
@tecpromotion @zero-24
[4.1] [SOC 21] Add a Scheduled Tasks Infrastructure to Joomla (#2166)
899ce9c 
* add new files and new strings

* fix #2157

* fix #2160

* fix #2158

* fix #2159

* fix #2161

* fix #2170

add two new strings

* fix #2171

* fix #2172

* fix #2173

* add translation plg_task_checkfiles

* add translation plg_task_demotask

* translation part 1

* fix #2179

* fix #2175

* fix #2196

* fix #2195

* just happy new year head

* translation plg_system_schedulerunner

* translation plg_system_tasknotification

* translation plg_task_requests

* language style

* translation plg_task_sitestatus

* translation plg_actionlog_joomla

* sounds better

* sounds nicer

* Update administrator/language/de-DE/plg_system_tasknotification.ini

thanks @zero-24

Co-authored-by: Tobias Zulauf <[email protected]>

* fix output

* language style

* fix #2220

* add new strings #2222

* fix #2222

* Update administrator/language/de-DE/com_scheduler.ini

Co-authored-by: Tobias Zulauf <[email protected]>

Co-authored-by: Tobias Zulauf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 4.x
Milestone
4.1.0.v1
Development

No branches or pull requests
3 participants
@tecpromotion @zero-24 @jgerman-bot