Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.1] [SOC 21] Add a Scheduled Tasks Infrastructure to Joomla #2166

Merged
merged 36 commits into from
Jan 15, 2022
Merged

[4.1] [SOC 21] Add a Scheduled Tasks Infrastructure to Joomla #2166

merged 36 commits into from
Jan 15, 2022

Conversation

tecpromotion
Copy link
Member

@tecpromotion tecpromotion commented Dec 8, 2021 •
edited
Loading

Pull Request für Issue #2134 .

Zusammenfassung der Änderungen

add new files and new strings

translation missing

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

backend

@tecpromotion tecpromotion marked this pull request as draft December 8, 2021 20:44
@tecpromotion tecpromotion self-assigned this Dec 8, 2021
@tecpromotion tecpromotion added this to the 4.1.0.v1 milestone Dec 8, 2021
This was linked to issues Dec 8, 2021
[4.1] [SOC 21] Add a Scheduled Tasks Infrastructure to Joomla #2134
Closed
[4.1] Move the new task ini files to the correct folder #2138
Closed
@tecpromotion tecpromotion linked an issue Dec 8, 2021 that may be closed by this pull request
[4.1] Tasks manager #2157
Closed
This was linked to issues Dec 8, 2021
[4.1] task titles #2160
Closed
[4.1] Tasks manager column heading #2158
Closed
@tecpromotion tecpromotion linked an issue Dec 8, 2021 that may be closed by this pull request
[4.1] Tasks site offline #2159
Closed
@tecpromotion tecpromotion linked an issue Dec 8, 2021 that may be closed by this pull request
[4.1] Tasks - empty state #2161
Closed
@tecpromotion
fix joomlagerman#2170
011e622 
add two new strings
@tecpromotion tecpromotion linked an issue Dec 11, 2021 that may be closed by this pull request
[4.1] Tasks enabled/disabled #2170
Closed
@tecpromotion tecpromotion linked an issue Dec 11, 2021 that may be closed by this pull request
[4.1] Simplify notification labels #2171
Closed
@tecpromotion tecpromotion linked an issue Dec 11, 2021 that may be closed by this pull request
[4.1] Remove ! in task title #2172
Closed
@tecpromotion tecpromotion mentioned this pull request Dec 11, 2021
Closed
@tecpromotion tecpromotion marked this pull request as ready for review January 6, 2022 20:27
@tecpromotion tecpromotion requested a review from a team January 6, 2022 20:27
@tecpromotion
Copy link
Member Author

@zero-24
Wir nutzen mal 'Exit-Code', mal 'HTTP-Statuscode', mal 'Antwortcode' und auch mal 'HTTP-Fehler-Code'.
Sollten wir das mal vereinheitlichen?

@zero-24
Copy link
Member

zero-24 commented Jan 7, 2022

@zero-24
Wir nutzen mal 'Exit-Code', mal 'HTTP-Statuscode', mal 'Antwortcode' und auch mal 'HTTP-Fehler-Code'.
Sollten wir das mal vereinheitlichen?

Grundsätzlich ja aber exit-code und HTTP Status code sind schon zwei unterschiedliche Dinge.

@tecpromotion
Copy link
Member Author

@zero-24
Wir nutzen mal 'Exit-Code', mal 'HTTP-Statuscode', mal 'Antwortcode' und auch mal 'HTTP-Fehler-Code'.
Sollten wir das mal vereinheitlichen?

Grundsätzlich ja aber exit-code und HTTP Status code sind schon zwei unterschiedliche Dinge.

Kommt immer auf den Kontext an. So sollte es ja derzeit passen.

@tecpromotion tecpromotion mentioned this pull request Jan 7, 2022
Closed
@tecpromotion tecpromotion requested a review from zero-24 January 12, 2022 17:21
@tecpromotion tecpromotion mentioned this pull request Jan 15, 2022
Closed
zero-24
zero-24 reviewed Jan 15, 2022
View reviewed changes
administrator/language/de-DE/com_scheduler.ini
COM_SCHEDULER_CONFIG_FIELDSET_LAZY_SCHEDULER_LABEL="Lazy-Zeitplaner"
COM_SCHEDULER_CONFIG_GENERATE_WEBCRON_KEY_DESC="Der Web-Cron benötigt einen Schlüssel zum Schutz, bevor er funktionsfähig ist. Konfiguration speichern, um den Schlüssel automatisch zu generieren."
COM_SCHEDULER_CONFIG_GLOBAL_WEBCRON_KEY_LABEL="Globaler Schlüssel"
COM_SCHEDULER_CONFIG_GLOBAL_WEBCRON_LINK_DESC="Wenn dieser Basislink aufrufen wird, werden standardmäßig nur Aufgaben ausgeführt, die zur Ausführung anstehen. Um eine bestimmte Aufgabe auszuführen, muss die ID der Aufgabe als Abfrageparameter, der an die URL angehängt werden: <code>BASE_URL&id=&lttask's id&gt</code>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
COM_SCHEDULER_CONFIG_GLOBAL_WEBCRON_LINK_DESC="Wenn dieser Basislink aufrufen wird, werden standardmäßig nur Aufgaben ausgeführt, die zur Ausführung anstehen. Um eine bestimmte Aufgabe auszuführen, muss die ID der Aufgabe als Abfrageparameter, der an die URL angehängt werden: <code>BASE_URL&id=&lttask's id&gt</code>"
COM_SCHEDULER_CONFIG_GLOBAL_WEBCRON_LINK_DESC="Wenn dieser Basislink aufrufen wird, werden standardmäßig nur Aufgaben ausgeführt, die zur Ausführung anstehen. Um eine bestimmte Aufgabe auszuführen, muss die ID der Aufgabe als Abfrageparameter, der an die URL angehängt werden: <code>BASE_URL&id=&lttaskId&gt</code>"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, da hast du recht, aber im Core ist es derzeit auch noch so drin.

Bildschirmfoto 2022-01-15 um 20 45 44

Ich habe das aber zum Anlass genommen und unter joomla/joomla-cms#36700 einen PR eingereicht.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danke

administrator/language/de-DE/com_scheduler.ini Outdated Show resolved Hide resolved
@tecpromotion tecpromotion requested a review from zero-24 January 15, 2022 20:42
@zero-24 zero-24 merged commit 899ce9c into joomlagerman:4.1-dev Jan 15, 2022
@zero-24
Copy link
Member

zero-24 commented Jan 15, 2022

Merged. Danke

@tecpromotion tecpromotion deleted the issue-2134 branch May 2, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zero-24 zero-24 zero-24 approved these changes

Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 4.x
Milestone
4.1.0.v1
2 participants
@tecpromotion @zero-24