Tags: Fixing routing #5105

Hackwar · 2014-11-14T20:59:22Z

I seriously don't know how this ever could have worked correctly...

We'll start by seeing that all tags that are associated with a language can not be reached, because they are stored in $lookup[$language][$view], but lookup later is only done on $lookup[$view]. So we are correcting this in a way that all tags are first of all associated with a language and then with a view. (See $lookup[$lang][$view])

Then we see that whatever we do, we override the caching of the lookup in line 151 anyway, so we can shorten that code tremendously.

Further we see that in line 159 the $language of the needles is overwritten with the $language from one random menu entry. This is done exactly once and not used thereafter, except that further cache lookups are stored as that $language. Since all this has no use anyway, we can simply remove this. (For reference, that parameter should somehow filter by language, but that is not the task of this class. That filtering has to be done earlier in the model.)

Last but not least, we are doing the lookup by both the view and the language.

This whole PR does not adress the fact that it does not support menu items with more than one tag, that there is only one view that it is checked against, that there is no fallback to the tags view, that _findItem() is only used in one method and thus completely unnecessary and could simply be merged into getTagRoute() and that it is doing A LOT of additional work that simply is not necessary. But at least this way it is a lot more correct and its behavior is more deterministically than before.

No testing instructions from me so far, since I found this during a code review. Asking a maintainer to review this.

zero-24 · 2014-11-14T22:02:39Z

components/com_tags/helpers/route.php

@@ -131,32 +131,23 @@ protected static function _findItem($needles = null)
 				{
 					if (isset($item->query) && isset($item->query['view']))
 					{
+						$lang = ($item->language != '' ? $item->language : '*');
+						if (!isset(self::lookup[$lang]))


@Hackwar can you add a clear line bevor the if statement

zero-24 · 2014-11-14T22:04:34Z

No testing instructions from me so far, since I found this during a code review. Asking a maintainer to review this.

Moving this to Needs Review. Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5105.

infograf768 · 2014-11-20T13:50:23Z

Although I have not tested this, careful with this one. Until now we have advised users to not assign languages to Tags but rather make sure they are filtered by setting com_tags Options "Language Filter" to "current".
(When using multilanguage)

ManuxGR · 2014-11-20T14:50:49Z

I just tested, site gets broken with this error.

Parse error: syntax error, unexpected '[', expecting '(' in *********/com_tags/helpers/route.php on line 136.

Joomla 3.3.6 multilanguage - My tags are assosiated with languages.

… com_tags_routing Conflicts: components/com_tags/helpers/route.php

…om_tags_routing

Hackwar · 2014-11-20T15:34:25Z

Sorry, that was a stupid bug. Fixed it.

ManuxGR · 2014-11-20T16:36:52Z

No worries. 👍 Tested and it's working properly. The file is up and running live.

We have some SEO issues with tags (like before).
I only have tested tags associated with languages.

Deleted tags don't redirect to 404 Error page, but to an empty page with the full template of the site. GWMT gives 404 Soft error for this links (empty page instead of 404 error)
2)Tags associated with languages working for all languages. Example: An english tag can be displayed to the Greek site like normal if you change the language code manually from url.

I have also changed the title of the tag for signle tag view from H2 to H1.

Hackwar · 2014-11-20T16:58:09Z

Regarding 1): That is the same behavior as before.
Regarding 2): That is also the same behavior as right now. The tags component currently simply does not seem to support languages at all...

The thing is, that this fixes a bunch of simple programming mistakes... This still needs a code review. 😄

ManuxGR · 2014-11-20T18:57:01Z

Yes, tags if used properly, they have a big impact to SEO. Tags should be fixed.

smanzi · 2014-12-01T17:53:15Z

@ManuxGR As you already tested this, can you please detail your testing methodology? Also, it seems that you have an success test, but in http://issues.joomla.org/tracker/joomla-cms/5105 it is still logged as a failure...

ManuxGR · 2014-12-01T19:03:59Z

@smanzi the failure was before the fix. Is there a way to change it? And this doesn't fix nothing. It's just the same code updated - modernized.

smanzi · 2014-12-01T19:13:10Z

@ManuxGR Yes, to fix your "vote" just go to http://issues.joomla.org/tracker/joomla-cms/5105 login with GitHub and change your vote.

zero-24 · 2014-12-01T19:13:34Z

@ManuxGR

the failure was before the fix. Is there a way to change it?

alter your test as "Not tested" and after this as "tested successfully"

Hackwar · 2014-12-09T17:46:12Z

While this fixes the TagsHelperRoute class up, the router is fixed in #5347. So please have a look there, too. Apply both PRs and it should make a world of difference. 😉

ssnobben · 2014-12-11T13:00:32Z

Thanks Hannes for your hard work on this important Joomla routing problem..Merry Christmas to you!

wilsonge · 2014-12-14T01:38:04Z

components/com_tags/helpers/route.php

@@ -88,14 +88,10 @@ public static function getTagRoute($id)
 		}
 		else
 		{
-			if (!empty($needles) && $item = self::_findItem($needles))
+			$link = 'index.php?option=com_tags&view=tag&id=' . $id;


Cause I'm an arse can we add a new line after above the if() statement please?

wilsonge · 2014-12-14T01:39:21Z

Maintainer Review: As there is no b/c being broken here and it's cleaning up the code hugely I'm happy with this in theory (note haven't tested). Please can we have some detailed test instructions tho :)

Hackwar · 2014-12-14T08:57:59Z

Fixed your codestyle remark.

As I wrote in my initial comment: I found this during a code review and don't have any idea which bugs I'm fixing with this... I just know that it is wrong...

wilsonge · 2014-12-29T14:32:27Z

components/com_tags/helpers/route.php

@@ -131,32 +128,23 @@ protected static function _findItem($needles = null)
 				{
 					if (isset($item->query) && isset($item->query['view']))
 					{
+						$lang = ($item->language != '' ? $item->language : '*');


Can we have a new line in between this line and the if statement please for code style

For you, I'd even add 2. 😉

wilsonge · 2014-12-30T02:21:51Z

@test couldn't find any issues with the patch when applied. Tried navigating around various tag views some attached to menu items some not. Merging.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5105.}

Fixing TagsHelperRoute class...

39f9a92

jissues-bot added the PR-staging label Nov 14, 2014

This was referenced Nov 14, 2014

Joomla Tag Menu Item Routing Broken #3191

Closed

tags lose active menu item on selection. #4243

Closed

Codestyle

3679615

zero-24 reviewed Nov 14, 2014
View reviewed changes

Codestyle

f40413c

dgrammatiko mentioned this pull request Nov 20, 2014

[SEO] - Deleted Tags not redirecting to 404 Error page. #5148

Closed

Hackwar added 3 commits November 20, 2014 16:28

Fixing stupid bugs.

4830429

Merge branch 'com_tags_routing' of github.com:Hackwar/joomla-cms into…

84413a1

… com_tags_routing Conflicts: components/com_tags/helpers/route.php

Merge branch 'staging' of https://github.com/joomla/joomla-cms into c…

3aba554

…om_tags_routing

Small optimization

8839725

smanzi mentioned this pull request Dec 1, 2014

Routing: Implementing routing stages #5264

Closed

Hackwar mentioned this pull request Dec 9, 2014

Fixing tag routing #5347

Merged

wilsonge reviewed Dec 14, 2014
View reviewed changes

Codestyle

593fd09

wilsonge reviewed Dec 29, 2014
View reviewed changes

Codestyle

a791662

wilsonge closed this in 183173c Dec 30, 2014

Hackwar deleted the com_tags_routing branch December 30, 2014 09:24

phproberto mentioned this pull request Mar 4, 2015

[fix] wrong link when tag is in a menu #6291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tags: Fixing routing #5105

Tags: Fixing routing #5105

Hackwar commented Nov 14, 2014

zero-24 Nov 14, 2014

zero-24 commented Nov 14, 2014

infograf768 commented Nov 20, 2014

ManuxGR commented Nov 20, 2014

Hackwar commented Nov 20, 2014

ManuxGR commented Nov 20, 2014

Hackwar commented Nov 20, 2014

ManuxGR commented Nov 20, 2014

smanzi commented Dec 1, 2014

ManuxGR commented Dec 1, 2014

smanzi commented Dec 1, 2014

zero-24 commented Dec 1, 2014

Hackwar commented Dec 9, 2014

ssnobben commented Dec 11, 2014

wilsonge Dec 14, 2014

wilsonge commented Dec 14, 2014

Hackwar commented Dec 14, 2014

wilsonge Dec 29, 2014

Hackwar Dec 29, 2014

wilsonge commented Dec 30, 2014

Tags: Fixing routing #5105

Tags: Fixing routing #5105

Conversation

Hackwar commented Nov 14, 2014

zero-24 Nov 14, 2014

Choose a reason for hiding this comment

zero-24 commented Nov 14, 2014

infograf768 commented Nov 20, 2014

ManuxGR commented Nov 20, 2014

Hackwar commented Nov 20, 2014

ManuxGR commented Nov 20, 2014

Hackwar commented Nov 20, 2014

ManuxGR commented Nov 20, 2014

smanzi commented Dec 1, 2014

ManuxGR commented Dec 1, 2014

smanzi commented Dec 1, 2014

zero-24 commented Dec 1, 2014

Hackwar commented Dec 9, 2014

ssnobben commented Dec 11, 2014

wilsonge Dec 14, 2014

Choose a reason for hiding this comment

wilsonge commented Dec 14, 2014

Hackwar commented Dec 14, 2014

wilsonge Dec 29, 2014

Choose a reason for hiding this comment

Hackwar Dec 29, 2014

Choose a reason for hiding this comment

wilsonge commented Dec 30, 2014