[4.1] Use emojis vs google fonts for the accessibility plugin #36948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 53640b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36948. |
1 similar comment
|
I have tested this item ✅ successfully on 53640b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36948. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36948. |
|
Can you hold on merging this. The script has been broken upstream |
|
Just checked and this change will actually resolve the bug upstream |
|
@brianteeman so it is ok now to merge? |
|
Well that depends. It has a side benefit of fixing #37050 which is an upstream bug. But it also exposes another upstream bug #37050 (comment) although thats much less severe. |
|
But both issues are expected to be patched upstream right? So i would say this can go in while upstream issues still have to be tracked. |
|
Is there an issue open we can reference here? |
|
Thanks |
|
Thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jun 8, 2022
joomla#36948 changed the icons in the accessibility from the google material font (because :privacy :facepalm) to use emojis. At the time this also resolved a bug in the upstream code that prevented the material font working on osx Upstream has now resolved the osx problem. This PR updates to the latest release of the script and introduces the ability to use either emoji or material icons. The default is emoji so there is no visible change etc on upgrade and no need for an update sql
laoneo
pushed a commit
that referenced
this pull request
Jun 14, 2022
* [4.1] accessibility plugin update and fixes #36948 changed the icons in the accessibility from the google material font (because :privacy :facepalm) to use emojis. At the time this also resolved a bug in the upstream code that prevented the material font working on osx Upstream has now resolved the osx problem. This PR updates to the latest release of the script and introduces the ability to use either emoji or material icons. The default is emoji so there is no visible change etc on upgrade and no need for an update sql * false * Update plugins/system/accessibility/accessibility.php Co-authored-by: Richard Fath <[email protected]> * refresh package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #36928
Summary of Changes
Set "useEmojis" as recommended by the docs: https://ranbuch.github.io/accessibility/#icon-image
Testing Instructions
Apply this PR and make sure no google fonts are loaded when using the accessibility plugin
Actual result BEFORE applying this Pull Request
Before this change the default value is used which uses google fonts.
Expected result AFTER applying this Pull Request
We no longer use google fonts but emojis.
Documentation Changes Required
none