-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility button does not appear (at least) on Safari 15 on MacOS 12 Monterey #36311
Comments
The accessibility javascript tries to load the material icons. On safari for some reason it can't and then loads an alternative which has the transparent background on an emoticon instead of the default material icon. This is the console message: Seem JS can't add the stylesheet to the page and that check fails so it adds a backup that is not styled correctly. Kind regards, |
It's all the same issue. Will pr later today |
Simplest way to solve the issue in the js is correcting the error: It should be |
I think you are confused between fontFamily and fontFaceSrc |
Nope. The js contains both loading the font family and a redundant font-family for the css. |
Hi Guys,
Maybe it is something for @dgrammatiko |
All of that must be made upstream |
what do you mean - at ranbuch account? |
The important thing is to get rid of Google fonts at all, as we have a GDPR problem here in Europe with Joomla! otherwise (or opt-in at least) |
@angieradtke these changes can only be made upstream at ranbuch. |
Benjamin told be we forked it already |
Sorry I was wrong, I thought about another script there |
I think needed changes are so massiv that a fork could make sence @dgrammatiko @chmst |
I don't know who downvoted this comment, but for german users without an annoying cookie-consent, using this plugin is not possible. https://www.gesetze-im-internet.de/ttdsg/ |
Among other things this is resolved by #36948 |
I have migrated 6 sites from 4.0 to 4.1.
The Accessibility button looks fine (with the wheelchair icon), but when opening it all icons there are broken. NB: in the meatime I see this issue had just been reported (with a fix mentioned by @brianteeman) : #37050 |
Its because the change made in the script was wrong and merged even though I stated several times it was wrong :( |
see #38009 |
please test #38009 |
Steps to reproduce the issue
This refers to https://www.facebook.com/groups/joomlanospam/posts/10158088758700997/
As can be seen on https://www.whatt.eu/en/ the accessibility button (bottom left, just above the cookie button, does appear on all browsers except (at least) on Safari 15 on MacOS 12 Monterey
See the Facebook thread for more screenshots and feedbacks
The text was updated successfully, but these errors were encountered: