Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info for enabling the workflow #35536

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Sep 12, 2021

Pull Request for Issue #34741 .

Summary of Changes

Add some information how to enable the workflow in J4.

Testing Instructions

Code review
or
apply patch, install sample data in a fresh installation and check the workflow text.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

@Valc
Copy link

Valc commented Sep 12, 2021

👍

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 3e09bc0

Language strings look good for this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@jwaisner
Copy link
Member

@Valc if you have tested, please mark your result on the tracker to confirm if successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@Valc
Copy link

Valc commented Sep 13, 2021

I have tested this item ✅ successfully on 3e09bc0

It is working fine here


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@Valc
Copy link

Valc commented Sep 13, 2021

Hi!
Is there other opened issue tracker to test about add a similar message at "post installation system messages"?
Due as new "hidden" by default and cool feature, now i am not able to see that one notified without install the same data.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@richard67
Copy link
Member

@chmst Wouldn't an ordered list haven been more suitable for the 3 steps for activating?

@chmst
Copy link
Contributor Author

chmst commented Sep 16, 2021

Nice idea, @richard67. Please test.

@ChristineWk
Copy link

I have tested this item ✅ successfully on c9a4b9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@ChristineWk
Copy link

Result:

screen shot 2021-09-19 at 21 30 49


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@ditsuke
Copy link
Contributor

ditsuke commented Sep 25, 2021

I have tested this item ✅ successfully on c9a4b9d

Looks good to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@richard67
Copy link
Member

@chmst Could you apply @brianteeman 's suggestions above? Thanks in advance.

@chmst
Copy link
Contributor Author

chmst commented Sep 29, 2021

thanks @brianteeman

@richard67
Copy link
Member

I've restored the previous two test results since the only change after that was a change in wording.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35536.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 29, 2021
@bembelimen bembelimen merged commit 6956e54 into joomla:4.0-dev Oct 5, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 5, 2021
@bembelimen
Copy link
Contributor

Thx

Kostelano added a commit to JPathRu/localisation that referenced this pull request Oct 7, 2021
@chmst chmst deleted the blog-sample-data-lang-workflow branch August 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants