-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Correct description for custom logging #34966
Conversation
This comment has been minimized.
This comment has been minimized.
I have tested this item ✅ successfully on 65a29c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
1 similar comment
I have tested this item ✅ successfully on 65a29c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
As the very next option is to change the list of categories for custom logging from include to exclude the text here is still not correct. Perhaps A comma separated list of log categories to include or exclude |
Back to pending. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
@Fedik Could you check @brianteeman 's suggestion? Thanks in advance. |
Co-authored-by: Brian Teeman <[email protected]>
I have tested this item ✅ successfully on ce1e724 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
1 similar comment
I have tested this item ✅ successfully on ce1e724 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966. |
Thx |
Summary of Changes
The description for Log Categories is incorrect.
When the field is empty then custom log is disabled:
joomla-cms/libraries/src/Application/CMSApplication.php
Lines 1400 to 1402 in b1f464c
Testing Instructions
Code review
Documentation Changes Required
If there a doc about it, then it also need to update.