Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Correct description for custom logging #34966

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jul 29, 2021

Summary of Changes

The description for Log Categories is incorrect.
When the field is empty then custom log is disabled:

if ($this->get('log_categories'))
{

Testing Instructions

Code review

Documentation Changes Required

If there a doc about it, then it also need to update.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jul 29, 2021
@Fedik

This comment has been minimized.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 65a29c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

1 similar comment
@RickR2H
Copy link
Member

RickR2H commented Oct 6, 2021

I have tested this item ✅ successfully on 65a29c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 6, 2021
@richard67 richard67 added this to the Joomla 4.0.4 milestone Oct 6, 2021
@brianteeman
Copy link
Contributor

As the very next option is to change the list of categories for custom logging from include to exclude the text here is still not correct.

Perhaps

A comma separated list of log categories to include or exclude

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Oct 6, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0.4 milestone Oct 6, 2021
@richard67
Copy link
Member

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

@richard67
Copy link
Member

@Fedik Could you check @brianteeman 's suggestion? Thanks in advance.

@richard67
Copy link
Member

I have tested this item ✅ successfully on ce1e724


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

1 similar comment
@RickR2H
Copy link
Member

RickR2H commented Oct 6, 2021

I have tested this item ✅ successfully on ce1e724


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34966.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 6, 2021
@richard67 richard67 added this to the Joomla 4.0.4 milestone Oct 6, 2021
@bembelimen bembelimen merged commit 5822eaa into joomla:4.0-dev Oct 7, 2021
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants