[4.0] Fix initial value of the Cassiopeia template style parameter "brand" for new installation and update and use it in error.php, too

[richard67]

Pull Request for #33751 (comment) .

Summary of Changes

1. Fix the outdated params values for the Cassiopeia template style in the base.sql files for new installation so they match to the default values in the XML file, including the changes from [4] New moduleposition below-top, option to switch off logo #33751 , [4.0] Cassopeia template and blog sample data fixes and improvements #31520 and possibly others.

2. Use default value 1 in call to $this->params->get for this parameter so it defaults to "Yes" if the values is not set in database e.g. after update from 4.0 Beta 7 or 3.10, which is the same default value as defined in the XML for that parameter.

3. Use the parameter also for the error page as mentioned in the description of PR [4] New moduleposition below-top, option to switch off logo #33751 :

The error page can be adapted if this is accepted.

4. Remove the height: 100vh; in the .error_site block of the templates/cassiopeia/scss/blocks/_modifiers.scss to get rid of the otherwise shown blue bar at the top or the error page when no header should be shown, see comment [4.0] Fix initial value of the Cassiopeia template style parameter "brand" for new installation and update and use it in error.php, too #33930 (comment) below.

Testing Instructions

Step 1: Use current 4.0-dev or the nightly build from May 18 or later to make a new installation.

Step 2: After the installation has finished, do not do anything else in backend.

Step 3: In frontend, check if the blue header section is shown.

Result: No blue header section.

Step 4: Apply the changes from this PR.

Step 5: Check again if the blue header section is shown in frontend.

Result: Blue header section with logo "Cassiopeia" and no site description is shown, like it was before PR #33751 was merged, because the default value in the $this->params->get call.

Step 6: Remove configuration.php, delete all tables in database and make again a new installation, still with the patch of this PR applied.

Step 7: After the installation has finished, do not do anything else in backend.

Step 8: In frontend, check if the blue header section is shown.

Result: Blue header section with logo "Cassiopeia" and no site description is shown, like it was before PR #33751 was merged, because the parameter has the right value in database.

Step 9: In backend, edit the Cassiopeia template style settings and check if the "Brand" parameter in advanced settings is switched on.

Result: The parameter is switched on.

Step 10: Check the error page by entering an unkown URL in frontend.

Result: Blue header section with logo "Cassiopeia" and no site description is shown.

Step 11: In backend, switch off the "Brand" parameter and save the changes.

Step 12: Check the front page and the error page on frontend if the blue header section is shown.

Result: The blue header is not shown anymore in frontend on normal and error page.

Actual result BEFORE applying this Pull Request

No blue header section with logo in frontend after a new installation or update from 3.10 or 4.0 Beta 7 and earlier without having saved template style settings.

See #33751 (comment) .

The error page doesn't respect the "Brand" parameter.

Expected result AFTER applying this Pull Request

Site shows the header with logo "Cassiopeia" on frontend after a new installation or update without having saved template style settings.

The error page respects the "Brand" parameter.

Documentation Changes Required

None.

[richard67]

Drone error is not related to this PR.

[hans2103]

Result: The blue header is not shown anymore in frontend on normal and error page.

this is not correct. Due to templates/cassiopeia/scss/blocks/_modifiers.scss line 6 .error_site { height: 100vh; } there is a blue line, depending on the height of the viewport

joomla-cms/templates/cassiopeia/scss/blocks/_modifiers.scss

Line 6 in 5371b92

height: 100vh;

by removal of the height, the blue bar is gone on the error page too.
Is it within the scope of this PR? Don't know.. but is easy fix

[hans2103]

see my comment... with or without the height I approve this PR.
#33930 (comment)

[richard67]

Result: The blue header is not shown anymore in frontend on normal and error page.

this is not correct. Due to templates/cassiopeia/scss/blocks/_modifiers.scss line 6 .error_site { height: 100vh; } there is a blue line, depending on the height of the viewport

joomla-cms/templates/cassiopeia/scss/blocks/_modifiers.scss

Line 6 in 5371b92

height: 100vh;

by removal of the height, the blue bar is gone on the error page too.
Is it within the scope of this PR? Don't know.. but is easy fix

Fixed, and PR description adapted.

[hans2103]

I have tested this item ✅ successfully on 3a494e2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33930.}

[wilsonge]

Thanks!

[wilsonge]

Merging this with only one good test because I want to have the sql updates in place for an RC in the next week or so

[richard67]

Thanks!