[4.0] Fix Cassiopeia template style parameters in database on new installation and update from 3.10 #33881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
changed the title
|
Closing in favour or #33930 . Please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for #33751 (comment) .
Summary of Changes
paramsvalues for the Cassiopeia template style in the base.sql files for new installation so they match to the default values in the XML file, including the changes from [4] New moduleposition below-top, option to switch off logo #33751 , [4.0] Cassopeia template and blog sample data fixes and improvements #31520 and possibly others.4.0.0-2016-10-02.sqlwith the sameparamsvalues when updating from 3.10.To be done
I have to check if it needs to do something for updates from previous J4 Beta versions. But this will be done with another PR, if necessary.
Testing Instructions
Please wait with testing. I might replace this PR by another, new one with a slightly different solution.
Test 1: New installation
Step 1: Use current 4.0-dev or the nightly build from tomorrow or later to make a new installation.
Step 2: After the installation has finished, do not do anything else in backend.
Step 3: In frontend, check if the blue header section is shown.
Result: No blue header section.
Step 4: Apply the changes from this PR.
Step 5: Remove configuration.php and delete all database tables.
Repeat steps 1 to 3.
Result: Blue header section with logo "Cassiopeia" and no site description is shown, like it was before PR #33751 was merged.
Test 2: Update from 3.10
Step 1: Update a current 3.10-dev or latest 3.10 nightly to the current 4.0-dev branch, which includes the merged PR #33751 .
Because there is no nightly build available with that yet, you have to use the following update package:
https://test5.richard-fath.de/Joomla_4.0.0-beta8-dev-Development-Update_Package_2021-05-14_20-22.zip
Step 2: After the update has finished, do not do anything else in backend.
Step 3: In frontend, check if the blue header section is shown.
Result: No blue header section.
Repeat steps 1 to 3, again starting with current 3.10-dev or latest 3.10 nightly, but this time update to the custom update URL or update package built by drone for this PR.
Result: Blue header section with logo "Cassiopeia" and no site description is shown, like it was before PR #33751 was merged.
Actual result BEFORE applying this Pull Request
No blue header section with logo in frontend after a new installation or update from 3.10 without having saved template style settings.
See #33751 (comment) .
Expected result AFTER applying this Pull Request
Site shows the header with logo "Cassiopeia" on frontend after a new installation or update from 3.10 without having saved template style settings.
Documentation Changes Required
None.