Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Smart Search: Fixing ordering, order direction and disabled button #29474

Merged
merged 6 commits into from
Jul 20, 2020

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 7, 2020

This again fixes several issues in Smart Search:

  • This adds the GUI option to sort also by title, besides relevance and the other options. The code was already in the model, but not accesible by GUI.
  • The ordering itself was broken and could not be influenced by the URI. A URL parameter was handed over, but never read.
  • Smart Search button disabled class not removed on entering data #18358 Simply said, I don't really understand why we should add the class "disabled" to a button just because the search is empty. The button still works the same as without that class and thus I'm rather removing this altogether.
  • The name from the button is removed, thus reducing the number of URL parameters.

Only works when #29428 is merged.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jun 7, 2020
@Quy
Copy link
Contributor

Quy commented Jun 11, 2020

Add option to Global Configuration > Smart Search.

@Quy
Copy link
Contributor

Quy commented Jun 11, 2020

PHP Warning: mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 420

() | JROOT\components\com_finder\src\View\Search\HtmlView.php:146
-- | --
2 | Joomla\Component\Finder\Site\View\Search\HtmlView->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:691
3 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT\components\com_finder\src\Controller\DisplayController.php:59
4 | Joomla\Component\Finder\Site\Controller\DisplayController->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:729
5 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:146
6 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:384
7 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\SiteApplication.php:201
8 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT\libraries\src\Application\SiteApplication.php:240
9 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:231
10 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\includes\app.php:63
11 | require_once() | JROOT\index.php:36

@Hackwar
Copy link
Member Author

Hackwar commented Jun 12, 2020

PHP Warning: mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 420

As I wrote, this PR doesn't work without the other PR being merged. This has happened in the meantime. This PR has been updated. Please test again.

@Quy
Copy link
Contributor

Quy commented Jun 12, 2020

Installed sample testing data.
Set Title for Sort Field.
Search results are not sorted by title.

@Hackwar
Copy link
Member Author

Hackwar commented Jul 6, 2020

@Quy should work now. Please test again.

@Quy
Copy link
Contributor

Quy commented Jul 6, 2020

I have tested this item ✅ successfully on bb2b688


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29474.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on bb2b688


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29474.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29474.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 10, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 added this to the Joomla 4.0 milestone Jul 20, 2020
@richard67 richard67 merged commit 876163b into joomla:4.0-dev Jul 20, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 20, 2020
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Jul 21, 2020
…outs

* '4.0-dev' of github.com:joomla/joomla-cms: (612 commits)
  [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474)
  [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007)
  [4.0] Get menu directly in com_tags menu route helper (joomla#30039)
  Remove collapse when resizing from mobile to desktop (joomla#30132)
  [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870)
  [4.0] Webauthn gmp warning (joomla#29731)
  [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694)
  [4.0] CLI help text (joomla#29811)
  Feature/draggable typo fixes (joomla#29987)
  [4.0] Removing unnecessary workaround in finder indexer (joomla#30037)
  [4.0] Optimizing Smart Search for larger content (joomla#30008)
  [4.0] Fix js ajax for pre update checker (joomla#29980)
  [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097)
  [4.0][com_fields] Fix draggable sorting (joomla#30094)
  [4.0] Correct incorrect @return documentation (joomla#30092)
  [4.0] Menu items modal: adding missing filters (joomla#30087)
  short to long php open tags with echo (joomla#30089)
  Use new Toolbar (joomla#30085)
  [4.0] Center status/date created headers (joomla#29249)
  [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077)
  ...

# Conflicts:
#	administrator/components/com_templates/src/View/Template/HtmlView.php
#	installation/sql/postgresql/base.sql
#	libraries/src/Application/AdministratorApplication.php
#	libraries/src/Application/SiteApplication.php
@Hackwar Hackwar deleted the j4findermisc branch July 22, 2020 09:56
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
…ton (joomla#29474)

* Fixing ordering, order direction and disabled button

* Codestyle

* Fixing ordering by title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants