[4.0] Center status/date created headers #29249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is only for smart search. |
Quy
changed the title
Quy
changed the title
|
Note that this issue is present in more places than addressed here. For example the date in articles list is centered but the header is not. |
|
Testing instructions updated. Ready for testing. |
|
I tested this and saw a clear difference at a width of 5000 pixels. I made the changes manually in the code for the view articles and code review for the other two files. centered not centered |
|
I have tested this item ✅ successfully on 177c446 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29249. |
1 similar comment
|
I have tested this item ✅ successfully on 177c446 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29249. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29249. |
|
Thanks! |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jul 21, 2020
…outs * '4.0-dev' of github.com:joomla/joomla-cms: (612 commits) [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474) [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007) [4.0] Get menu directly in com_tags menu route helper (joomla#30039) Remove collapse when resizing from mobile to desktop (joomla#30132) [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870) [4.0] Webauthn gmp warning (joomla#29731) [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694) [4.0] CLI help text (joomla#29811) Feature/draggable typo fixes (joomla#29987) [4.0] Removing unnecessary workaround in finder indexer (joomla#30037) [4.0] Optimizing Smart Search for larger content (joomla#30008) [4.0] Fix js ajax for pre update checker (joomla#29980) [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097) [4.0][com_fields] Fix draggable sorting (joomla#30094) [4.0] Correct incorrect @return documentation (joomla#30092) [4.0] Menu items modal: adding missing filters (joomla#30087) short to long php open tags with echo (joomla#30089) Use new Toolbar (joomla#30085) [4.0] Center status/date created headers (joomla#29249) [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077) ... # Conflicts: # administrator/components/com_templates/src/View/Template/HtmlView.php # installation/sql/postgresql/base.sql # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/SiteApplication.php
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* Center status header * Center date created header * Center status cell in featured article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Center status header to match with its td cell.
Testing Instructions
Code review.
or
Go to Content > Articles
See Date Created header right-aligned vs. center-aligned in Featured Articles.
Go to Content > Featured Articles
See Status header left-aligned.
(Optional to better see the alignment issue in Smart Search) Install https://github.com/C-Lodder/joomla4-backend-template/releases
Go to System > Administrator Template Styles
Set Bettum the default.
Go to Components > Smart Search > Index
See Status header left-aligned.
Go to Components > Smart Search > Filters
See Status header left-aligned.
Expected result
Table header/cell respectively should be center-aligned.