-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Change com_templates to services #20619
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
47ae523
Change com_templates to services
laoneo 9f93fa4
Revert file
laoneo 8410c48
Merge branch '4.0-dev' into j4/services/templates
laoneo c37e26a
cs
laoneo 82151d1
Merge remote-tracking branch 'origin/j4/services/templates' into j4/s…
laoneo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
administrator/components/com_templates/Extension/TemplatesComponent.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
/** | ||
* @package Joomla.Administrator | ||
* @subpackage com_templates | ||
* | ||
* @copyright Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved. | ||
* @license GNU General Public License version 2 or later; see LICENSE.txt | ||
*/ | ||
|
||
namespace Joomla\Component\Templates\Administrator\Extension; | ||
|
||
defined('JPATH_PLATFORM') or die; | ||
|
||
use Joomla\CMS\Extension\BootableExtensionInterface; | ||
use Joomla\CMS\Extension\MVCComponent; | ||
use Joomla\CMS\HTML\HTMLRegistryAwareTrait; | ||
use Joomla\Component\Templates\Administrator\Service\HTML\Templates; | ||
use Psr\Container\ContainerInterface; | ||
|
||
/** | ||
* Component class for com_templates | ||
* | ||
* @since 4.0.0 | ||
*/ | ||
class TemplatesComponent extends MVCComponent implements BootableExtensionInterface | ||
{ | ||
use HTMLRegistryAwareTrait; | ||
|
||
/** | ||
* Booting the extension. This is the function to set up the environment of the extension like | ||
* registering new class loaders, etc. | ||
* | ||
* If required, some initial set up can be done from services of the container, eg. | ||
* registering HTML services. | ||
* | ||
* @param ContainerInterface $container The container | ||
* | ||
* @return void | ||
* | ||
* @since 4.0.0 | ||
*/ | ||
public function boot(ContainerInterface $container) | ||
{ | ||
$this->getRegistry()->register('templates', new Templates); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
administrator/components/com_templates/helpers/template.php
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
administrator/components/com_templates/helpers/templates.php
This file was deleted.
Oops, something went wrong.
54 changes: 54 additions & 0 deletions
54
administrator/components/com_templates/services/provider.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
<?php | ||
/** | ||
* @package Joomla.Administrator | ||
* @subpackage com_templates | ||
* | ||
* @copyright Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved. | ||
* @license GNU General Public License version 2 or later; see LICENSE.txt | ||
*/ | ||
|
||
defined('_JEXEC') or die; | ||
|
||
use Joomla\CMS\Dispatcher\DispatcherFactoryInterface; | ||
use Joomla\CMS\Extension\ComponentInterface; | ||
use Joomla\CMS\Extension\MVCComponent; | ||
use Joomla\CMS\Extension\Service\Provider\DispatcherFactory; | ||
use Joomla\CMS\Extension\Service\Provider\MVCFactoryFactory; | ||
use Joomla\CMS\MVC\Factory\MVCFactoryFactoryInterface; | ||
use Joomla\DI\Container; | ||
use Joomla\DI\ServiceProviderInterface; | ||
|
||
/** | ||
* The templates service provider. | ||
* | ||
* @since 4.0.0 | ||
*/ | ||
return new class implements ServiceProviderInterface | ||
{ | ||
/** | ||
* Registers the service provider with a DI container. | ||
* | ||
* @param Container $container The DI container. | ||
* | ||
* @return void | ||
* | ||
* @since 4.0.0 | ||
*/ | ||
public function register(Container $container) | ||
{ | ||
$container->registerServiceProvider(new MVCFactoryFactory('\\Joomla\\Component\\Templates')); | ||
$container->registerServiceProvider(new DispatcherFactory('\\Joomla\\Component\\Templates')); | ||
|
||
$container->set( | ||
ComponentInterface::class, | ||
function (Container $container) | ||
{ | ||
$component = new MVCComponent($container->get(DispatcherFactoryInterface::class)); | ||
|
||
$component->setMvcFactoryFactory($container->get(MVCFactoryFactoryInterface::class)); | ||
|
||
return $component; | ||
} | ||
); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this. These un-namespaced classes are so generically named - I think rather just have the empty deprecated classes that people need to require :/ @mbabker do you have any strong opinions?