-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Change com_templates to services #20619
Conversation
Cant test on the front end because of #20356 |
But you can test on the back end? Front end is routing through com_config thats why #20356 will be fixed there too. |
and i am saying that AFTER applying this PR i still get the error in #20356 |
ah i see what you meant now. as i said in #20620 it cant be tested with patchtester so it makes it harder to test - dont have time to do that right now |
libraries/extensions.classmap.php
Outdated
@@ -14,3 +14,6 @@ | |||
JLoader::registerAlias('FieldsListPlugin', '\\Joomla\\Component\\Fields\\Administrator\\Plugin\\FieldsListPlugin', '4.0'); | |||
|
|||
JLoader::registerAlias('TagsTableTag', '\\Joomla\\Component\\Tags\\Administrator\\Table\\TagTable', '4.0'); | |||
|
|||
JLoader::registerAlias('TemplatesHelper', '\\Joomla\\Component\\Templates\\Administrator\\Helper\\TemplatesHelper', '5.0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this. These un-namespaced classes are so generically named - I think rather just have the empty deprecated classes that people need to require :/ @mbabker do you have any strong opinions?
When viewing |
@infograf768 Please test #20649 |
Moves com_templates to the service based extension setup.
See #20217 for details.