Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Change com_templates to services #20619

Merged
merged 5 commits into from
May 31, 2018

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 29, 2018

Moves com_templates to the service based extension setup.

See #20217 for details.

@brianteeman
Copy link
Contributor

Cant test on the front end because of #20356

@laoneo
Copy link
Member Author

laoneo commented May 29, 2018

But you can test on the back end? Front end is routing through com_config thats why #20356 will be fixed there too.

@brianteeman
Copy link
Contributor

and i am saying that AFTER applying this PR i still get the error in #20356

@brianteeman
Copy link
Contributor

ah i see what you meant now. as i said in #20620 it cant be tested with patchtester so it makes it harder to test - dont have time to do that right now

@@ -14,3 +14,6 @@
JLoader::registerAlias('FieldsListPlugin', '\\Joomla\\Component\\Fields\\Administrator\\Plugin\\FieldsListPlugin', '4.0');

JLoader::registerAlias('TagsTableTag', '\\Joomla\\Component\\Tags\\Administrator\\Table\\TagTable', '4.0');

JLoader::registerAlias('TemplatesHelper', '\\Joomla\\Component\\Templates\\Administrator\\Helper\\TemplatesHelper', '5.0');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this. These un-namespaced classes are so generically named - I think rather just have the empty deprecated classes that people need to require :/ @mbabker do you have any strong opinions?

@wilsonge wilsonge merged commit 6ee625f into joomla:4.0-dev May 31, 2018
@wilsonge wilsonge deleted the j4/services/templates branch May 31, 2018 08:55
@wilsonge wilsonge added this to the Joomla 4.0 milestone May 31, 2018
@infograf768
Copy link
Member

When viewing administrator/index.php?option=com_templates&view=templates
I get a 500 JHtml templates not found.
@laoneo

@anuragteapot
Copy link
Contributor

@infograf768 Please test #20649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants