[4.0] Fix content margin if no "top" modules are assigned #17699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the Windows lines endings in the CSS file. |
|
I have tested this item ✅ successfully on 3689e4b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17699. |
|
I have tested this item ✅ successfully on 3689e4b Tested successfullyThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17699. |
|
RTC after two successful tests. |
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Aug 31, 2017
…olandd-4.0-dev * '4.0-dev' of https://github.com/joomla/joomla-cms: (35 commits) Delete redis handler in favor of fw handler (joomla#17798) Remove deprecated JArrayHelper (joomla#17795) [4.0] codestyle (joomla#17779) Update error renderers for PHP 7 code structure, update Exception/Throwable references to only reference Throwable (joomla#17750) Improve article association links Fix parsing routes with language filter enabled Fix JString use [4.0] Fix content margin if no "top" modules are assigned (joomla#17699) Removed required state for Secret Key field (joomla#17713) [4.0] [installation] set proper default for lastResetTime (joomla#16847) [4.0] Remove FOF From Joomla Core (joomla#17687) [4.0] Add Controller suffix to extension controllers (joomla#17624) Fix menu association form field not loading remove html imports (joomla#17691) [4.0] Update Bootstrap to beta-1 (joomla#17496) Move files [4.0] Cleanup classmap and include it properly for stubs generation (joomla#17667) Add back class that got deleted somewhere Fix Sql field class name (joomla#17666) [4.0] Fix namespaced form fields Part 2 (joomla#17664) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #17698
Summary of Changes
This PR fixes the top margin that should be assigned to any
<div>that comes after the header. The issue before was the scope of the CSS.Testing Instructions
bannerand all modules assigned to thetop-aandtop-bpositions.There should be a space between the header and next element.