[4.0] Update Bootstrap to beta-1 #17496
Conversation
media/system/scss/_jalert.scss
Outdated
|
|
||
| .alert-message { | ||
| @include alert-variant(theme-color("success"), theme-color("success"), $gray-200); | ||
| } |
There was a problem hiding this comment.
Files should end with a trailing newline
| @@ -0,0 +1,265 @@ | |||
| (function () { | |||
There was a problem hiding this comment.
@C-Lodder you need to remove the tab files, it's not ready for merging yet
There was a problem hiding this comment.
It they're being compile but not merged, then they should probably be ignored in th
he Gruntfile.js
There was a problem hiding this comment.
Gruntfile is totally stupid (and that's the way it should be), it copies all the files from the dist/js to the media/system/webcomponents.
There was a problem hiding this comment.
Hmm ok. Will revert that file
|
Please ping when it is ready for testing |
|
will do, thanks @brianteeman |
|
@brianteeman - apart from the first 2 things on the "to-do" list mentioned in my initial comment, could you give this a once over to see if anything drastic is going wrong, that would be appreciated. FYI you will need to reinstall Joomla to get the background colour variants on the demo modules for Aurora. |
|
My four hour train journey from an unnamed location in the middle of Wales is almost over so I will have to put this on the todo list for tomorrow am as I suspect I am about to fall asleep in the keyboard |
|
Some of the fonts seem to be different sizes for example
|
|
and there is a difference here as well - maybe its padding - not sure only a quick check
|
|
And another font size difference
|
|
@C-Lodder login font size and alert font size are now ok thanks - toolbar still the same |
|
@brianteeman fixed |
|
@wilsonge - This is good to go now. If there are however any glitches I've missed, a new issue can be opened. |
|
Can this be merged now please? |
|
Thanks all |
…olandd-4.0-dev * '4.0-dev' of https://github.com/joomla/joomla-cms: (35 commits) Delete redis handler in favor of fw handler (joomla#17798) Remove deprecated JArrayHelper (joomla#17795) [4.0] codestyle (joomla#17779) Update error renderers for PHP 7 code structure, update Exception/Throwable references to only reference Throwable (joomla#17750) Improve article association links Fix parsing routes with language filter enabled Fix JString use [4.0] Fix content margin if no "top" modules are assigned (joomla#17699) Removed required state for Secret Key field (joomla#17713) [4.0] [installation] set proper default for lastResetTime (joomla#16847) [4.0] Remove FOF From Joomla Core (joomla#17687) [4.0] Add Controller suffix to extension controllers (joomla#17624) Fix menu association form field not loading remove html imports (joomla#17691) [4.0] Update Bootstrap to beta-1 (joomla#17496) Move files [4.0] Cleanup classmap and include it properly for stubs generation (joomla#17667) Add back class that got deleted somewhere Fix Sql field class name (joomla#17666) [4.0] Fix namespaced form fields Part 2 (joomla#17664) ...
WIP
This PR updates Bootstrap to beta-1 which was released this morning. There's still a lot of fixes to be made to cater for ther B/C breaks, so probably not much point in testing.
Do NOT merge!
To-Do
alpha-6andbeta-1