Add showon attribute to add mailto link parameter #16282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on f26b5ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16282. |
1 similar comment
|
I have tested this item ✅ successfully on f26b5ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16282. |
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
May 31, 2017
* staging: (1779 commits) Deprecate modules correction (joomla#16362) Removed unnecessary code in com_content (joomla#14628) Stop installation if minimum requirement isn't met. (joomla#15890) Deprecate parts of com_modules (joomla#16152) LICENSE.txt (joomla#16317) [a11y] [com_fields] icons in modals (joomla#15047) Load jQuery in associations edit layout (joomla#16240) HHVM was removed. Remove from travis conditionals (joomla#16281) Fix Stylesheet Mime type keeping b/c (joomla#16284) re-merge joomla#15068 and joomla#16256 Add showon attribute to add mailto link parameter (joomla#16282) Fix notices on Contact form (joomla#16279) Updating dutch TinyMCE files Media upload form margin (joomla#16253) Changes to display atom feeds correctly (joomla#16105) admin mod_latest (joomla#16277) Add truncate class and implement in popular articles module (joomla#16257) Using the "Special:MyLanguage" tag for links pointing to docs.joomla.org (joomla#15858) Change email notification to use site from address (Fix joomla#9261) (joomla#13518) Fix double encode ampersand in contact select list value (joomla#16268) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PR to add the showon attribute to the "Add Mailto: Link" as suggested by @infograf768 here #16268 (comment)
Testing Instructions
Expected result
If the "Email" parameter is set to "Hide", the parameter "Add Mailto: Link" should be hidden and only appear when "Email" was set to "Show".
Actual result
Before the patch, the "Add Mailto: Link" is always visible.