Stop extension installation if minimum requirement isn't met. #15890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specified minimum version is a valid version.
Bakual
changed the title
wilsonge
approved these changes
May 8, 2017
|
@Bakual if you can provide an extension to use for testing it will get tested faster :) |
|
Sure thing. I've adjusted my component so it requires Joomla 3.7.3 and PHP 7.1.0 as minimum. |
|
I have tested this item ✅ successfully on 864de80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15890. |
1 similar comment
|
I have tested this item ✅ successfully on 864de80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15890. |
|
@Bakual see how quick that was :) |
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
May 31, 2017
* staging: (1779 commits) Deprecate modules correction (joomla#16362) Removed unnecessary code in com_content (joomla#14628) Stop installation if minimum requirement isn't met. (joomla#15890) Deprecate parts of com_modules (joomla#16152) LICENSE.txt (joomla#16317) [a11y] [com_fields] icons in modals (joomla#15047) Load jQuery in associations edit layout (joomla#16240) HHVM was removed. Remove from travis conditionals (joomla#16281) Fix Stylesheet Mime type keeping b/c (joomla#16284) re-merge joomla#15068 and joomla#16256 Add showon attribute to add mailto link parameter (joomla#16282) Fix notices on Contact form (joomla#16279) Updating dutch TinyMCE files Media upload form margin (joomla#16253) Changes to display atom feeds correctly (joomla#16105) admin mod_latest (joomla#16277) Add truncate class and implement in popular articles module (joomla#16257) Using the "Special:MyLanguage" tag for links pointing to docs.joomla.org (joomla#15858) Change email notification to use site from address (Fix joomla#9261) (joomla#13518) Fix double encode ampersand in contact select list value (joomla#16268) ...
Bakual
pushed a commit
to Bakual/SermonSpeaker
that referenced
this pull request
Jun 1, 2017
Bakual
pushed a commit
to Bakual/SermonSpeaker
that referenced
this pull request
Nov 21, 2017
Bakual
pushed a commit
to Bakual/SermonSpeaker
that referenced
this pull request
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3447 introduced a new class
JInstallerScriptwhich allows to specify a minimum PHP and Joomla version for extensions by simply setting the respective property in the extensions script file (assuming it extends that class).The check is done during the
preflightstage.Summary of Changes
Testing Instructions
If you have an extension already using those features, test that it works as expected. Adjust the minimum versions and check that installation succeeds/fails as expected.
Expected result
If the installation doesn't meet the minimum requirements, the extension should not install.
If the installation meets exactly the minimum requirements, the extension should install without any message.
Actual result
Installation isn't aborted at all and if the minimum requirement is met exactly, the message is still shown.
Documentation Changes Required
None
Pinging @wilsonge since he was the original writer of those lines.