Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbsnails-media class - fixes BS 'thumbnail' class #13406

Merged
merged 1 commit into from
Dec 30, 2016

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Dec 29, 2016

Pull Request for Issue #13349 & #13383.

Summary of Changes

Adds a unique class for changes in #12643, ensuring these changes only effect the media manager.

Testing Instructions

Apply patch and check styling of any 3rd party extension using the BS 'thumbnail' class . Instance also in core #13383 (Install from Web).

Documentation Changes Required

No

@Bakual

@ciar4n ciar4n changed the title Add thumbsnails-media class - fixes BS 'thumbnail' class Add thumbnails-media class - fixes BS 'thumbnail' class Dec 29, 2016
@Bakual
Copy link
Contributor

Bakual commented Dec 29, 2016

I have tested this item ✅ successfully on 87105c4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13406.

@ghost
Copy link

ghost commented Dec 29, 2016

I have tested this item ✅ successfully on 87105c4

Test only on "Install from Web" cause don't know, which 3rd party extensions are using the BS 'thumbnail' class.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13406.

@joomla-cms-bot joomla-cms-bot changed the title Add thumbnails-media class - fixes BS 'thumbnail' class Add thumbsnails-media class - fixes BS 'thumbnail' class Dec 29, 2016
@joomla-cms-bot joomla-cms-bot added PR-staging RTC This Pull Request is Ready To Commit and removed PR-staging labels Dec 29, 2016
@dgrammatiko
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13406.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Dec 30, 2016
@zero-24 zero-24 merged commit 0e48339 into joomla:staging Dec 30, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 30, 2016
@zero-24
Copy link
Contributor

zero-24 commented Dec 30, 2016

Merged. Thanks 👍

@ciar4n ciar4n deleted the thumbnail-media branch December 30, 2016 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants