Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Thumbnails broken in Isis #13349

Closed
Bakual opened this issue Dec 23, 2016 · 4 comments
Closed

Bootstrap Thumbnails broken in Isis #13349

Bakual opened this issue Dec 23, 2016 · 4 comments

Comments

@Bakual
Copy link
Contributor

Bakual commented Dec 23, 2016

Steps to reproduce the issue

Take any extension which uses the Bootstrap Thumbnails feature (http://getbootstrap.com/2.3.2/components.html#thumbnails) and see how ugly that looks in staging.

As an example you can use my component SermonSpeaker (eg http://www.sermonspeaker.net/download/sermonspeaker-component/sermonspeaker-component-5-5-4.html) and in backend go to "Extensions -> SermonSpeaker). That brings you to a "dashboard" view using Thumbnails.

Expected result

old

Actual result

new

System information (as much as possible)

Joomla 3.6.5 vs staging

Additional comments

I think this comes from #12643.
That PR added a block to restyle thumbnails here: https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/less/template.less#L1523-L1692

I think those rules need a id or class prefix so they only apply to media manager related output and not all thumbnails in any extension.

@Bakual
Copy link
Contributor Author

Bakual commented Dec 23, 2016

@ciar4n Can you have a look at this?

@ciar4n
Copy link
Contributor

ciar4n commented Dec 23, 2016

Thanks @Bakual I'm off the radar for the christmas but will sort this out in a few days. As suggested I'll give the media manager a unique class regarding #12643.

@Bakual
Copy link
Contributor Author

Bakual commented Dec 27, 2016

See also #13383 (Install from Web) where this is broken as well. So we even have a place in core.

@zero-24
Copy link
Contributor

zero-24 commented Dec 29, 2016

There is a PR thanks @ciar4n at #13406

@zero-24 zero-24 closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants