Fix: symlinking (build and deploy) under Windows works now even if paths contain spaces #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Escaping paths when creating symlinks, so this works with paths containing spaces.
ramalama
changed the title
for files symlink must not contain the option /J
file symlink needs admin privileges or developer mode under windows. Hard link (mklink /H) works without elevation and should be good enough for the use case.
Zip Files are treated as files under Windows, so you must use is_file for checking and unlink for deletion.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added escape quotes for the paths, so creating symlinks works event if paths contain spaces.
Fixed symlink for package zip files (windows)