Fix: symlinking (build and deploy) under Windows works now even if pa…

…ths contain spaces (#86)
joomla-projects · Mar 3, 2024 · 42588eb · 42588eb
1 parent e341c26
commit 42588eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Tasks/Build.php b/src/Tasks/Build.php
@@ -53,7 +53,7 @@ public function run()
             if (is_dir($this->params['base'] . "\dist\current")) {
                 rmdir($this->params['base'] . "\dist\current");
             }
-            $this->taskExec('mklink /J ' . $this->params['base'] . '\dist\current ' . $this->getWindowsPath($this->getBuildFolder()))
+            $this->taskExec('mklink /J "' . $this->params['base'] . '\dist\current" "' . $this->getWindowsPath($this->getBuildFolder()) . '"')
                 ->run();
         } else {
             if (is_dir($this->params['base'] . "/dist/current")) {

diff --git a/src/Tasks/Deploy/Package.php b/src/Tasks/Deploy/Package.php
@@ -97,10 +97,10 @@ public function run()
 
         // Create symlink to current folder
         if ($this->isWindows()) {
-            if (is_dir($this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip")) {
-                rmdir($this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip");
+            if (is_file($this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip")) {
+                unlink($this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip");
             }
-            $this->taskExec('mklink /J ' . $this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip" . ' ' . $this->getWindowsPath($this->target))
+            $this->taskExec('mklink /H "' . $this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip" . '" "' . $this->getWindowsPath($this->target) . '"')
                 ->run();
         } else {
             if (is_dir($this->params['base'] . "\dist\pkg-" . $this->getExtensionName() . "-current.zip")) {