Merge pull request #226 from jonhoo/wikipedia-changed #144
This check has been archived and is scheduled for deletion.
Learn more about checks retention
GitHub Actions / clippy
succeeded
Aug 13, 2023 in 0s
clippy
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.72.0-beta.8 (598a0a3cb 2023-08-12)
- cargo 1.72.0-beta.8 (44b6be4bd 2023-08-03)
- clippy 0.1.72 (598a0a3 2023-08-12)
Annotations
Check warning on line 212 in src/key.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/key.rs:212:25
|
212 | String::new() + &self + rhs
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 212 in src/key.rs
github-actions / clippy
taken reference of right operand
warning: taken reference of right operand
--> src/key.rs:212:9
|
212 | String::new() + &self + rhs
| ^^^^^^^^^^^^^^^^-----
| |
| help: use the right value directly: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
Check warning on line 809 in src/session.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> src/session.rs:809:55
|
809 | let body = match serde_json::from_str(&*body)? {
| ^^^^^^ help: try this: `&body`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 744 in src/session.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/session.rs:740:36
|
740 | base64::encode(&format!(
| ____________________________________^
741 | | "{}:{}",
742 | | url.username(),
743 | | url.password().unwrap_or("")
744 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
help: change this to
|
740 ~ base64::encode(format!(
741 + "{}:{}",
742 + url.username(),
743 + url.password().unwrap_or("")
744 ~ ))
|
Loading