Skip to content

Merge pull request #226 from jonhoo/wikipedia-changed #144

Merge pull request #226 from jonhoo/wikipedia-changed

Merge pull request #226 from jonhoo/wikipedia-changed #144

Triggered via push August 13, 2023 10:07
Status Failure
Total duration 11m 3s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

test.yml

on: push
ubuntu / stable / minimal-versions
9m 47s
ubuntu / stable / minimal-versions
ubuntu / stable / coverage
10m 48s
ubuntu / stable / coverage
Matrix: required
Fit to window
Zoom out
Zoom in

Annotations

1 error and 8 warnings
macos-latest / firefox / stable
Process completed with exit code 101.
this expression creates a reference which is immediately dereferenced by the compiler: src/key.rs#L212
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/key.rs:212:25 | 212 | String::new() + &self + rhs | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
taken reference of right operand: src/key.rs#L212
warning: taken reference of right operand --> src/key.rs:212:9 | 212 | String::new() + &self + rhs | ^^^^^^^^^^^^^^^^----- | | | help: use the right value directly: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
deref which would be done by auto-deref: src/session.rs#L809
warning: deref which would be done by auto-deref --> src/session.rs:809:55 | 809 | let body = match serde_json::from_str(&*body)? { | ^^^^^^ help: try this: `&body` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
the borrowed expression implements the required traits: src/session.rs#L740
warning: the borrowed expression implements the required traits --> src/session.rs:740:36 | 740 | base64::encode(&format!( | ____________________________________^ 741 | | "{}:{}", 742 | | url.username(), 743 | | url.password().unwrap_or("") 744 | | )) | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default help: change this to | 740 ~ base64::encode(format!( 741 + "{}:{}", 742 + url.username(), 743 + url.password().unwrap_or("") 744 ~ )) |
this expression creates a reference which is immediately dereferenced by the compiler: src/key.rs#L212
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/key.rs:212:25 | 212 | String::new() + &self + rhs | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
taken reference of right operand: src/key.rs#L212
warning: taken reference of right operand --> src/key.rs:212:9 | 212 | String::new() + &self + rhs | ^^^^^^^^^^^^^^^^----- | | | help: use the right value directly: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
deref which would be done by auto-deref: src/session.rs#L809
warning: deref which would be done by auto-deref --> src/session.rs:809:55 | 809 | let body = match serde_json::from_str(&*body)? { | ^^^^^^ help: try this: `&body` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
the borrowed expression implements the required traits: src/session.rs#L740
warning: the borrowed expression implements the required traits --> src/session.rs:740:36 | 740 | base64::encode(&format!( | ____________________________________^ 741 | | "{}:{}", 742 | | url.username(), 743 | | url.password().unwrap_or("") 744 | | )) | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default help: change this to | 740 ~ base64::encode(format!( 741 + "{}:{}", 742 + url.username(), 743 + url.password().unwrap_or("") 744 ~ )) |