fix: do not disable submit button on warnings on Send page #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made a small adjustment to be more explicit in the button text:
|
dergigi
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the submit button on the Send page has been disabled, if the requirements for collaborative transactions were not met.
After this PR, the warnings are still displayed, but the button is enabled and a payment can be attempted.
Why this change? The functionality has been disabled, as single collaborative transactions have no retry mechanism in place (unlike the scheduled sweep) and users had no real hint on how to recover, in case a transaction gets "stuck". With #497 resolved, users can now abort/cancel single collaborative transactions, hence the button can safely be enabled.
However, if preconditions are not fulfilled, the transaction will likely either get "stuck" (e.g. when a utxo with <5 confs is used) or will be aborted by the server (20% rule, no retries left) - there is no good way of communicating this to the user other than the current warnings.
Additional Change:
Question: The warning texts have not been changed. Do you think they should be adapted and need rephrasing?