feat: abort collaborative transaction #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
enhancement
theborakompanioni
force-pushed
the
stop-collaborative-transaction
branch
from
b783e0e to
96cb08f
Compare
8 tasks
Let's leave it as is and see how many users run into these kinds of issues in the wild. |
dergigi
approved these changes
Sep 16, 2022
|
Notes to self:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269.
Adds the ability to abort a running taker operation.
How to test
You might want to watch the logs while testing this feature with
npm run regtest:logs:jmwalletdQuestion: Currently, the text only says "Are you sure you want to abort the collaborative transaction?"..
Stopping a taker operation might lead to end up wasting a "retry" (when commitment was already sourced).. Should it mention that it might lead to inconveniences if this is used "too much in a row"? How to communicate this best?