Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3447 Gitlab time submission #3483

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix #3447 Gitlab time submission #3483

merged 2 commits into from
Sep 17, 2024

Conversation

d-r-e
Copy link
Contributor

@d-r-e d-r-e commented Sep 17, 2024

Description

The tasks used the internal ID when retrieving Gitlab issues. With this change, it uses the issue number, so that time submission works again. Tested locally with an on-premise Gitlab instance.

Issues Resolved

#3447

Check List

  • New functionality includes testing. N/A
  • New functionality has been documented in the README if applicable. N/A

d-r-e and others added 2 commits September 17, 2024 09:04
Fixed an error reported in johannesjo#3447 for which the issueId instead of iid was used for time submission to Gitlab.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there d-r-e! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@johannesjo johannesjo merged commit a85d004 into johannesjo:master Sep 17, 2024
6 checks passed
@johannesjo
Copy link
Owner

Thank you very much!

@d-r-e d-r-e mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants