Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab time reporting fails because issue.id is used instead of issue.iid #3447

Closed
Blackclaws opened this issue Sep 12, 2024 · 2 comments
Closed
Labels

Comments

@Blackclaws
Copy link

Your Environment

  • Version used: 10.0.4
  • Operating System and version: Archlinux
  • Desktop Environment: XFCE

Expected Behavior

Time tracking works

Current Behavior

Time tracking does not work but returns 404 because the id instead of the iid is used

Steps to Reproduce (for bugs)

  1. Sync issues from gitlab
  2. Work
  3. Sync time to gitlab
  4. 404 not found

Can you reproduce this reliably?

Yes

Console Output

Basically 404 not found

What is wrong

Essentially the problem is that Superproductivity in the later versions (anything that includes the 9577c3e commit) uses the issue id for certain gitlab things instead of the iid, breaking multiple interactions. This should either be reverted or the iid should be used in the correct places.

@Blackclaws Blackclaws added the bug label Sep 12, 2024
Copy link

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

@johannesjo
Copy link
Owner

Possibly related #3300

d-r-e added a commit to d-r-e/super-productivity that referenced this issue Sep 17, 2024
Fixed an error reported in johannesjo#3447 for which the issueId instead of iid was used for time submission to Gitlab.
johannesjo added a commit that referenced this issue Sep 18, 2024
* d-r-e-master:
  test(e2e): fix schedule tests being unreliable
  10.0.8
  fix: backlog button shown when it shouldn't #3488
  Removed unnecessary comments
  Fix Gitlab Time Input (part 2)
  Fix # 3447 time submitting used wrong id on Gitlab
  Fix #3447 Time submission on Gitlab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants