Changing Player design #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 Fix crash in ErrorApp
✨ Change sort options to apply per tab
🐛 Fix vertical padding in artist/genre lists
|
This looks good to me, is there anything that needs to be changed before this is merged? There was some discussion in the redesign issue about how the album/artist chips shouldn't be chips, but other than that this looks good |
|
@jmshrv in the redesign issue was discussed to switch the menu button to the top. Maybe i will have time later that day to do this. |
|
@jmshrv now i switched it. Ready to merge :) |
|
|
|
Looks great, merged :) |
|
Hold on, @Y0ngg4n. On the right side, the shuffle toggle and like button should be switched as well :) Should hopefully only take a minute or so... Thanks! |
|
@Chaphasilor ah yeah thank you i will change that the next days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.