Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix crash in ErrorApp #404

Merged
merged 1 commit into from
Feb 21, 2023
Merged

🐛 Fix crash in ErrorApp #404

merged 1 commit into from
Feb 21, 2023

Conversation

Maxr1998
Copy link
Collaborator

Currently, the error app crashes due to AppLocalization.of(context) returning null.
This is apparently a bug in Flutter, and worked around by adding another widget wrapping the Scaffold.

@jmshrv
Copy link
Owner

jmshrv commented Feb 21, 2023

That's a very strange edge case, thanks for somehow finding a fix :)

@jmshrv jmshrv merged commit 7d56b1f into jmshrv:main Feb 21, 2023
@Maxr1998
Copy link
Collaborator Author

Sure thing, I noticed it when introducing some other bugs while working on something else. Glad it was this easily fixable 😄

@Maxr1998 Maxr1998 deleted the fix-error-app branch February 21, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants