Prevent incomplete files from sticking around in the object store cache.

Maybe fixes galaxyproject#18117.
jmchilton · May 14, 2024 · fb21610 · fb21610
1 parent 4147b38
commit fb21610
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/galaxy/objectstore/_caching_base.py b/lib/galaxy/objectstore/_caching_base.py
@@ -104,7 +104,10 @@ def _pull_into_cache(self, rel_path) -> bool:
             os.makedirs(self._get_cache_path(rel_path_dir), exist_ok=True)
         # Now pull in the file
         file_ok = self._download(rel_path)
-        fix_permissions(self.config, self._get_cache_path(rel_path_dir))
+        if file_ok:
+            fix_permissions(self.config, self._get_cache_path(rel_path_dir))
+        else:
+            unlink(self._get_cache_path(rel_path), ignore_errors=True)
         return file_ok
 
     def _get_data(self, obj, start=0, count=-1, **kwargs):