Overhaul Object Store Backends #18117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with service account and user accounts keys. Settings -> Interoperability to create HMAC keys.
Eliminate CloudConfigMixin... This got copid and pasted over and over and each place just used once. Really odd reading of my original code but I guess I understand why people did it.
Fixes biggest issue with galaxyproject#16438 - IMO anyway.
jmchilton
force-pushed
the
overhaul_object_stores
branch
from
9923d29 to
8d060b3
Compare
mvdbeek
reviewed
May 9, 2024
|
This is breaking a single test still: def test_admin_build_data_bundle_by_uri(self):
original_count = self._testbeta_field_count()
history_id = self.dataset_populator.new_history()
payload = self.dataset_populator.run_tool_payload(
tool_id="data_manager",
inputs={"ignored_value": "moo"},
data_manager_mode="bundle",
history_id=history_id,
)
create_response = self._post("tools", data=payload)
create_response.raise_for_status()
self.dataset_populator.wait_for_history(history_id, assert_ok=True)
data_manager_dataset = self.dataset_populator.get_history_dataset_details(history_id)
assert data_manager_dataset["extension"] == "data_manager_json"
post_job_count = self._testbeta_field_count()
assert original_count == post_job_count
shutil.rmtree(self.object_store_cache_path)
os.makedirs(self.object_store_cache_path)
content = self.dataset_populator.get_history_dataset_content(
history_id, to_ext="data_manager_json", type="bytes"
)
temp_directory = decompress_bytes_to_directory(content)
> assert os.path.exists(os.path.join(temp_directory, "newvalue.txt"))
E AssertionError: assert False
E + where False = <function exists at 0x7fdf1957f0d0>('/tmp/tmpnrvoj4c7/tmp9e__od17/newvalue.txt')
E + where <function exists at 0x7fdf1957f0d0> = <module 'posixpath' from '/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/posixpath.py'>.exists
E + where <module 'posixpath' from '/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/posixpath.py'> = os.path
E + and '/tmp/tmpnrvoj4c7/tmp9e__od17/newvalue.txt' = <function join at 0x7fdf1957fa60>('/tmp/tmpnrvoj4c7/tmp9e__od17', 'newvalue.txt')
E + where <function join at 0x7fdf1957fa60> = <module 'posixpath' from '/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/posixpath.py'>.join
E + where <module 'posixpath' from '/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/posixpath.py'> = os.path |
|
Unit test that might replicate what is happening with the test case.
|
jmchilton
force-pushed
the
overhaul_object_stores
branch
4 times, most recently
from
18453e4 to
5aa3519
Compare
- Fix s3 which broke during the migration because we stopped adding a / I thought was silly. - Use the test case I wrote that mimics the integration test failure to also fix the boto3 and azure_blob object stores for these failures. Also make note of a lingering issue that is pretty important
jmchilton
force-pushed
the
overhaul_object_stores
branch
from
62d23b6 to
9d1ba54
Compare
|
Tracking that last bug down... meant adding a test case and finding many more existing bugs that predate this PR. I think the overall result from all of the fixes that resulted from those tests is that all of the objectstores are now much less buggy when it comes to extra files handling before this refactoring began. The comments in the last few commits make it clear what I found and such - probably worth reviewing those commits. |
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
May 11, 2024
2 tasks
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
May 14, 2024
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
May 14, 2024
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
May 14, 2024
4 tasks
|
Closing in favor of #18136. That PR has all of this plus some nice test improvements and fixes discovered by those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the changes?
(Select all options that apply)
License