Resolve the app's config instead of using ember-get-config
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Apr 14, 2022
| import { isNone } from '@ember/utils'; | ||
| import { closest } from './-private/closest-string'; | ||
| import { macroCondition, isDevelopingApp } from '@embroider/macros'; | ||
|
|
||
| const REGISTERED_ARGS = Symbol('args'); | ||
| const INTERCEPT_CLASS = 'ForbidExtraArgsIntercept'; | ||
|
|
||
| function shouldThrowErrors(): boolean { | ||
| function shouldThrowErrors(owner: any): boolean { |
There was a problem hiding this comment.
I can also pass along the actual config instead of the owner, maybe that's less "weird", though that's a bit more work on the invocation side.
|
Was also wondering if it would make more sense to change EDIT: Regardless if the issues with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main motivation for this switch is this issue: mansona/ember-get-config#39.