Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App config is now included 3 times in final build #39

Closed
bertdeblock opened this issue Apr 11, 2022 · 0 comments · Fixed by #41
Closed

App config is now included 3 times in final build #39

bertdeblock opened this issue Apr 11, 2022 · 0 comments · Fixed by #41

Comments

@bertdeblock
Copy link
Contributor

bertdeblock commented Apr 11, 2022

An app's config has always been included as a meta tag in the app's index.html file (unless you set storeConfigInMeta to false, then the actual config object is included inside the config module).

Since v1.0.0 of this addon, an app's config is now also included in vendor.js.
Since v1.0.3 of this addon, an app's test config is now also included in vendor.js (even for production builds).

I don't feel this is the right direction to take.
I think the focus should be more on resolving the app's config at runtime as mentioned in the beginning of this addon's README.

If I'm not mistaken, this also breaks the flow for companies who build their app once and then create different configured versions of their app by replacing the meta tag in index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant