Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timezone using timezone-js. #45

Closed
wants to merge 1 commit into from

Conversation

chotiwat
Copy link

A pull request for #38. Please review. Thanks.

@jkbrzt
Copy link
Owner

jkbrzt commented May 30, 2014

Thanks, @chotiwat! There seem to be many failing tests — do they not fail for you?

@chotiwat
Copy link
Author

Oh, I forgot to mention that you need to install Olson time zone files into tests/vendor/tz. Please see https://github.com/mde/timezone-js#setup for the installation instruction.

All tests passed perfectly for me on Firefox. However, on Chromium-based browsers, you need to set up a static web server since they don't allow AJAX requests on local time zone files. And there will be one failing test, saying "America/New_York" is not loaded, which can be fixed by delaying that test for a few seconds with setTimeout.

@jkbrzt
Copy link
Owner

jkbrzt commented Jun 1, 2014

Thanks a lot. The approach now being discussed in #38 might actually be even a better solution (i.e., using UTC instead of local timezone). Let's see if that would be possible to implement before merging this in.

@arolson101
Copy link
Collaborator

Hi! I'm trying to clear out bugs and PRs. If this PR is still wanted/relevant, please comment and/or fix the conflicts!

@kourge kourge mentioned this pull request Jun 18, 2018
@davidgoli
Copy link
Collaborator

Closing due to inactivity.

@davidgoli davidgoli closed this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants