Add typings for rrulestr
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgoli
reviewed
Jun 21, 2018
index.d.ts
Outdated
| @@ -172,6 +172,18 @@ declare namespace RRule { | |||
|
|
|||
| function fromString(value: string): RRule; | |||
|
|
|||
| function rrulestr(s: string, options?: RRuleStrOptions): RRule; | |||
There was a problem hiding this comment.
One point: this might return an RRule OR an RRuleSet. So it might be better typed RRule | RRuleSet.
|
This is great! When can we expect it to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216. The
tzinfosoption is left untyped because it is not used at all due to the lack of timezone support. (See #45.)