Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: The first instance of a reccuring event after end of daylight saving time is one day to early #213

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

HolgerFrank
Copy link
Contributor

Dump: FREQ=WEEKLY;DTSTART=20181003T080000Z;COUNT=10;WKST=MO;BYDAY=WE
1 Wed Oct 03 2018 10:00:00 GMT+0200 (Mitteleuropäische Sommerzeit)
2 Wed Oct 10 2018 10:00:00 GMT+0200 (Mitteleuropäische Sommerzeit)
3 Wed Oct 17 2018 10:00:00 GMT+0200 (Mitteleuropäische Sommerzeit)
4 Wed Oct 24 2018 10:00:00 GMT+0200 (Mitteleuropäische Sommerzeit)
5 Tue Oct 30 2018 10:00:00 GMT+0100 (Mitteleuropäische Zeit)
6 Wed Nov 07 2018 10:00:00 GMT+0100 (Mitteleuropäische Zeit)
7 Wed Nov 14 2018 10:00:00 GMT+0100 (Mitteleuropäische Zeit)
8 Wed Nov 21 2018 10:00:00 GMT+0100 (Mitteleuropäische Zeit)
9 Wed Nov 28 2018 10:00:00 GMT+0100 (Mitteleuropäische Zeit)
10 Wed Dec 05 2018 10:00:00 GMT+0100 (Mitteleuropäische Zeit)

Holger Frank added 2 commits May 30, 2018 13:59
…ving time is one day early

Dump: FREQ=WEEKLY;DTSTART=20181003T080000Z;COUNT=10;WKST=MO;BYDAY=WE
1	Wed	Oct	03	2018	10:00:00	GMT+0200	(Mitteleuropäische	Sommerzeit)
2	Wed	Oct	10	2018	10:00:00	GMT+0200	(Mitteleuropäische	Sommerzeit)
3	Wed	Oct	17	2018	10:00:00	GMT+0200	(Mitteleuropäische	Sommerzeit)
4	Wed	Oct	24	2018	10:00:00	GMT+0200	(Mitteleuropäische	Sommerzeit)
5	Tue	Oct	30	2018	10:00:00	GMT+0100	(Mitteleuropäische	Zeit)
6	Wed	Nov	07	2018	10:00:00	GMT+0100	(Mitteleuropäische	Zeit)
7	Wed	Nov	14	2018	10:00:00	GMT+0100	(Mitteleuropäische	Zeit)
8	Wed	Nov	21	2018	10:00:00	GMT+0100	(Mitteleuropäische	Zeit)
9	Wed	Nov	28	2018	10:00:00	GMT+0100	(Mitteleuropäische	Zeit)
10	Wed	Dec	05	2018	10:00:00	GMT+0100	(Mitteleuropäische	Zeit)
@HolgerFrank
Copy link
Contributor Author

Important previous commits:
Make it work with date before 1970 #183 => This is an important correction to calculate correct ordinals before 1970

Following commits were (partly) removed:

Copy link

@arvanis arvanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakubroztocil This fix works as expected and it would be nice if you could merge it - it's opened since May and I really need it in my project. I had a lot of problems with rrule, especially in Asian dates. It was missing the first or the last day of the period. That one changed line and three deleted lines fixed all the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants