Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with date before 1970 #183

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Conversation

bubbatls
Copy link
Contributor

The Math.abs was the cause of the weird behavior

The Math.abs was the cause of the weird behavior
@arolson101
Copy link
Collaborator

Can you explain why Math.abs was wrong?

@bubbatls
Copy link
Contributor Author

bubbatls commented Feb 5, 2018

because the lib needs a signed delta not an unsigned one.

@arolson101
Copy link
Collaborator

Sorry, I don't know the code that well.
Would you mind adding a test to your PR?

@bubbatls
Copy link
Contributor Author

bubbatls commented Feb 7, 2018

I see the test folder but I dont' understand how to execute them (I use chrome) so I will not add a test without testing it.

@arolson101
Copy link
Collaborator

The tests are run via command-line- clone the repo, run npm install, then npm test
If you want you can just reply with an example of it failing I will write the test.

@bubbatls
Copy link
Contributor Author

bubbatls commented Feb 7, 2018

I've made a pull request with a test that should work but don't without the current fix

@arolson101 arolson101 merged commit 5335e67 into jkbrzt:master Feb 7, 2018
@arolson101
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants