-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update git2 to use libgit2 1.9 #5315
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rui Chen <[email protected]>
There isn't a build of libgit2 1.9 for Nix yet, so I'm not sure we want to pull the trigger on this just yet. Or we need to update the Flake to build libgit2 out-of-band. |
I did not know that nix did not have a libgit2 1.9 build yet, but yeah, this PR can certainly wait for libgit2 1.9 on the nix side. |
For the flake you should be able to just temporarily the |
Can you also please adhere to the commit style outlined by this document here: https://github.com/jj-vcs/jj/blob/main/docs/contributing.md#code-reviews. Thanks, my suggestion is either |
There’s a bit of a catch‐22 here: NixOS/nixpkgs#373096 updates I guess we can apply this patch on the Nixpkgs end for now to break the cycle. |
The As the Arch Linux packager working through the libgit2-1.9 todo list, I can say we're probably going to have to provide a 1.8 compat package for a while. Nix may end up having to do the same, there are a few upstream projects that are not easily patched one direction or the other. Jujutsu was pretty easy (we just back ported this bump and everything worked) but some other tools are not playing so nice. |
Checklist
If applicable:
CHANGELOG.md