Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream is a pretty low key version bump, but it changes the git2 crate dependency specifically to enable building against libgit2-1.9. This also means that it requires the latest libgit2 to link against, at least the way we have it setup now with
export LIBGIT2_NO_VENDER=1
. Since the libgit2 bump doesn't seem to be in progress yet, what should happen with version bumps like this (note this is far from the only Rust based project with libgit2 support in the same boat here, and I know from packaging them on Arch Linux that many of them are getting upstream version bumps). Should I temporarily allow this to vendor the library? Or leave it as draft?Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.