Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-warp-time: 0.8.4 → 0.8.5 #372663

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

git-warp-time: 0.8.4 → 0.8.5 #372663

wants to merge 1 commit into from

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Jan 10, 2025

Upstream is a pretty low key version bump, but it changes the git2 crate dependency specifically to enable building against libgit2-1.9. This also means that it requires the latest libgit2 to link against, at least the way we have it setup now with export LIBGIT2_NO_VENDER=1. Since the libgit2 bump doesn't seem to be in progress yet, what should happen with version bumps like this (note this is far from the only Rust based project with libgit2 support in the same boat here, and I know from packaging them on Arch Linux that many of them are getting upstream version bumps). Should I temporarily allow this to vendor the library? Or leave it as draft?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alerque alerque changed the title decasify: 0.8.4 → 0.8.5 git-warp-time: 0.8.4 → 0.8.5 Jan 10, 2025
@alerque
Copy link
Contributor Author

alerque commented Jan 10, 2025

I similar question about how to handle Nix not (yet) having libgit2-1.9 has come up over on Jujutsu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant