Backport parseURLParams from jitsi-meet #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wiechert <[email protected]>
|
@hristoterezov You were right about wanting to factor this one out to js-utils 😅 |
csett86
approved these changes
Aug 25, 2022
|
Tested, now config.disableChatSmileys=true works as intended in the electron app as well |
|
Thank you for your contribution, @psi-4ward |
TallTed
reviewed
Sep 27, 2022
|
|
||
|
|
||
| /** | ||
| * A list if keys to ignore when parsing. |
There was a problem hiding this comment.
typo
Suggested change
| * A list if keys to ignore when parsing. | |
| * A list of keys to ignore when parsing. |
| * returns them as a JS object. | ||
| * | ||
| * @param {URL} url - The URL to parse. | ||
| * @param {boolean} dontParse - If falsy, some transformations (for parsing the |
There was a problem hiding this comment.
typo
Suggested change
| * @param {boolean} dontParse - If falsy, some transformations (for parsing the | |
| * @param {boolean} dontParse - If false, some transformations (for parsing the |
| * @param {URL} url - The URL to parse. | ||
| * @param {boolean} dontParse - If falsy, some transformations (for parsing the | ||
| * value as JSON) will be executed. | ||
| * @param {string} source - If {@code 'search'}, the parameters will parsed out |
There was a problem hiding this comment.
typo
Suggested change
| * @param {string} source - If {@code 'search'}, the parameters will parsed out | |
| * @param {string} source - If {@code 'search'}, the parameters will be parsed out |
d3473r
pushed a commit
to d3473r/jitsi-meet-electron
that referenced
this pull request
Sep 1, 2023
Used https://github.com/jitsi/jitsi-meet/blob/master/react/features/base/util/parseURLParams.ts and removed the typescript stuff and replaced deprecated substr() Closes: jitsi#642 Signed-off-by: Christoph Wiechert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used https://github.com/jitsi/jitsi-meet/blob/master/react/features/base/util/parseURLParams.ts and removed the typescript stuff and replaced deprecated
substr()Ref: #642
Signed-off-by: Christoph Wiechert [email protected]
CLA already signed