JSON.parse for URL-Params missing

[psi-4ward]

In
https://github.com/jitsi/jitsi-meet-electron/blob/master/app/features/conference/components/Conference.js#L216
we do not JSON.parse() the values of URL-Params (like config.channelLastN=0) which leads to errors cause it's all strings.

https://github.com/jitsi/jitsi-meet/blob/master/react/features/base/util/parseURLParams.js#L57

[psi-4ward]

const hashParameters = url.hash.substring(1).split('&')
            .reduce((res, item) => {
                // eslint-disable-next-line prefer-const
                let [ key, value ] = item.split('=');

                try {
                    const decoded = decodeURIComponent(value).replace(/\\&/, '&');

                    value = decoded === 'undefined' ? undefined : Bourne.parse(decoded);
                } catch (e) {
                    console.warn(`Failed to parse URL parameter value: ${String(value)}`, e);
                }
                res[key] = value;

                return res;
            }, {});

[saghul]

Yep we should parse them. Would you be willing to write a patch?

[csett86]

As asked today in the community call, this also is an issue for parameters that are boolean, eg. disableChatSmileys=true, as also they are then all strings and not boolean.

[psi-4ward]

Oh damn. Lost that.

In another project I'll try to guess the type from the default value.