Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 정기배포 #604

Merged
merged 3 commits into from
Jul 30, 2023
Merged

ci: 정기배포 #604

merged 3 commits into from
Jul 30, 2023

Conversation

jimin52
Copy link
Member

@jimin52 jimin52 commented Jul 30, 2023

변경점

  • 모노레포 적용
  • 도커파일 변경
  • v2 api 일부 구현

scarf005 and others added 2 commits July 26, 2023 17:25
@scarf005 @nyj001012 @middlefitting
feat!: ts-rest v2 전환, review 경로 구현 (#589)
a0b12cd 
* build: 모노레포 준비

* build: ts-rest, @jiphyeonjeon-42/contracts, ts-pattern, rome 추가

* build: `@ts-rest/express`내부 타입을 드러내도록 패치

Co-authored-by: Ji-Hyuck, Min <[email protected]>
Co-authored-by: yena <[email protected]>

* ci: 워크스페이스 패키지 적용

* feat: reviews contract 및 백엔드 구현

Co-authored-by: yena <[email protected]>
Co-authored-by: SeungChul Chung <[email protected]>
Co-authored-by: Ji-Hyuck, Min <[email protected]>

---------

Co-authored-by: Ji-Hyuck, Min <[email protected]>
Co-authored-by: yena <[email protected]>
Co-authored-by: SeungChul Chung <[email protected]>
@scarf005
refactor: reviews impl.ts을 역할에 따라 분리 (#602)
6c7ad8e 
* refactor: controller.ts를 `controller/` 디렉터리로 이동

* refactor: 서비스 DI를 `service/impl.ts`로 이동

* refactor: 컨트롤러 DI를 `controller/impl.ts`로 이동
@jimin52 jimin52 temporarily deployed to development July 30, 2023 05:05 — with GitHub Actions Inactive
@scarf005 scarf005 changed the title 정기배포 ci: 정기배포 Jul 30, 2023
@jimin52 jimin52 marked this pull request as draft July 30, 2023 05:25
@scarf005 scarf005 temporarily deployed to development July 30, 2023 05:33 — with GitHub Actions Inactive
@jimin52 jimin52 marked this pull request as ready for review July 30, 2023 05:38
scarf005
scarf005 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scarf005 scarf005 requested a review from nyj001012 July 30, 2023 05:42
@jimin52 jimin52 requested review from YeonSeong-Lee and removed request for YeonSeong-Lee July 30, 2023 05:43
nyj001012
nyj001012 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimin52 jimin52 merged commit 3a81b3d into main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarf005 scarf005 scarf005 approved these changes

@nyj001012 nyj001012 nyj001012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimin52 @nyj001012 @scarf005