Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reviews impl.ts을 역할에 따라 분리 #602

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

scarf005
Copy link
Member

개요

작업 사항

기존 impl.ts는

  • 서비스 의존성 (typeorm repository) 주입
  • 컨트롤러 의존성 (서비스) 주입
  • ts-rest 라우터 의존성 (컨트롤러) 주입

을 하나의 파일에서 진행했기 때문에 한 번에 한 가지 기능만 수행하도록 service와 controller 경로로 impl.ts 파일을 쪼갰습니다.

@scarf005 scarf005 requested review from nyj001012 and Yonaim July 29, 2023 09:53
@scarf005 scarf005 linked an issue Jul 29, 2023 that may be closed by this pull request
@scarf005 scarf005 temporarily deployed to development July 29, 2023 09:53 — with GitHub Actions Inactive
@scarf005 scarf005 changed the title refactor: reviews impl.ts 파일일 분리을 역할에 따라 분리 refactor: reviews impl.ts을 역할에 따라 분리 Jul 29, 2023
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scarf005 scarf005 merged commit 6c7ad8e into develop Jul 29, 2023
@scarf005 scarf005 deleted the 601-implts-파일-분리 branch July 29, 2023 10:06
nyj001012 pushed a commit that referenced this pull request Jul 31, 2023
* refactor: controller.ts를 `controller/` 디렉터리로 이동

* refactor: 서비스 DI를 `service/impl.ts`로 이동

* refactor: 컨트롤러 DI를 `controller/impl.ts`로 이동
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl.ts 파일 분리
2 participants