refactor: reviews impl.ts을 역할에 따라 분리

backend/src/v2/reviews/controller.ts → backend/src/v2/reviews/controller/controller.ts

@@ -7,9 +7,9 @@ import {
   bookInfoNotFound,
   getUser,
   reviewNotFound,
-} from '../shared';
-import { ReviewsService } from './service';
-import { ReviewNotFoundError } from './service/errors';
+} from '../../shared';
+import { ReviewsService } from '../service';
+import { ReviewNotFoundError } from '../service/errors';
 
 type PostDeps = Pick<ReviewsService, 'createReview'>;
 type MkPost = (services: PostDeps) => HandlerFor<typeof contract.reviews.post>;
@@ -21,11 +21,15 @@ export const mkPostReviews: MkPost =
 
     return match(result)
       .with(P.instanceOf(BookInfoNotFoundError), () => bookInfoNotFound)
-      .otherwise(() => ({ status: 201, body: '리뷰가 작성되었습니다.' } as const));
+      .otherwise(
+        () => ({ status: 201, body: '리뷰가 작성되었습니다.' } as const),
+      );
   };
 
 type PatchDeps = Pick<ReviewsService, 'toggleReviewVisibility'>;
-type MkPatch = (services: PatchDeps) => HandlerFor<typeof contract.reviews.patch>;
+type MkPatch = (
+  services: PatchDeps,
+) => HandlerFor<typeof contract.reviews.patch>;
 export const mkPatchReviews: MkPatch =
   ({ toggleReviewVisibility }) =>
   async ({ params: { reviewsId }, req: { user } }) => {
@@ -34,7 +38,13 @@ export const mkPatchReviews: MkPatch =
 
     return match(result)
       .with(P.instanceOf(ReviewNotFoundError), () => reviewNotFound)
-      .otherwise(() => ({ status: 200, body: '리뷰 공개 여부가 업데이트되었습니다.' } as const));
+      .otherwise(
+        () =>
+          ({
+            status: 200,
+            body: '리뷰 공개 여부가 업데이트되었습니다.',
+          } as const),
+      );
   };
 
 type PutDeps = Pick<ReviewsService, 'updateReview'>;
@@ -54,7 +64,9 @@ export const mkPutReviews: MkPut =
   };
 
 type DeleteDeps = Pick<ReviewsService, 'removeReview'>;
-type MkDelete = (services: DeleteDeps) => HandlerFor<typeof contract.reviews.delete>;
+type MkDelete = (
+  services: DeleteDeps,
+) => HandlerFor<typeof contract.reviews.delete>;
 export const mkDeleteReviews: MkDelete =
   ({ removeReview }) =>
   async ({ params: { reviewsId }, req: { user } }) => {

backend/src/v2/reviews/controller/impl.ts

@@ -0,0 +1,14 @@
+import { ReviewsService } from '../service';
+import {
+  mkDeleteReviews,
+  mkPatchReviews,
+  mkPostReviews,
+  mkPutReviews,
+} from './controller';
+
+export const implReviewController = (service: ReviewsService) => ({
+  post: mkPostReviews(service),
+  patch: mkPatchReviews(service),
+  put: mkPutReviews(service),
+  delete: mkDeleteReviews(service),
+});

backend/src/v2/reviews/controller/index.ts

@@ -0,0 +1 @@
+export * from "./controller";

backend/src/v2/reviews/impl.ts

@@ -1,43 +1,18 @@
 import { contract } from '@jiphyeonjeon-42/contracts';
 import { initServer } from '@ts-rest/express';
-import jipDataSource from '~/app-data-source';
-import BookInfo from '~/entity/entities/BookInfo';
-import Reviews from '~/entity/entities/Reviews';
 import { roleSet } from '~/v1/auth/auth.type';
 import authValidate from '~/v1/auth/auth.validate';
 
-import { Repository } from 'typeorm';
-import { mkDeleteReviews, mkPatchReviews, mkPostReviews, mkPutReviews } from './controller';
-import {
-  ReviewsService as ReviewService,
-  mkCreateReview,
-  mkRemoveReview,
-  mkToggleReviewVisibility,
-  mkUpdateReview,
-} from './service';
-
-const implReviewService = (repos: {
-  reviews: Repository<Reviews>;
-  bookInfo: Repository<BookInfo>;
-}) => ({
-  createReview: mkCreateReview(repos),
-  removeReview: mkRemoveReview(repos),
-  updateReview: mkUpdateReview(repos),
-  toggleReviewVisibility: mkToggleReviewVisibility(repos),
-});
-
-const implReviewController = (service: ReviewService) => ({
-  post: mkPostReviews(service),
-  patch: mkPatchReviews(service),
-  put: mkPutReviews(service),
-  delete: mkDeleteReviews(service),
-});
+import jipDataSource from '~/app-data-source';
+import BookInfo from '~/entity/entities/BookInfo';
+import Reviews from '~/entity/entities/Reviews';
+import { implReviewController } from './controller/impl';
+import { implReviewService } from './service/impl';
 
 const service = implReviewService({
   reviews: jipDataSource.getRepository(Reviews),
   bookInfo: jipDataSource.getRepository(BookInfo),
 });
-
 const handler = implReviewController(service);
 
 const s = initServer();

backend/src/v2/reviews/service/impl.ts

@@ -0,0 +1,19 @@
+import { Repository } from 'typeorm';
+import type BookInfo from '~/entity/entities/BookInfo';
+import type Reviews from '~/entity/entities/Reviews';
+import {
+  mkCreateReview,
+  mkRemoveReview,
+  mkToggleReviewVisibility,
+  mkUpdateReview,
+} from './service';
+
+export const implReviewService = (repos: {
+  reviews: Repository<Reviews>;
+  bookInfo: Repository<BookInfo>;
+}) => ({
+  createReview: mkCreateReview(repos),
+  removeReview: mkRemoveReview(repos),
+  updateReview: mkUpdateReview(repos),
+  toggleReviewVisibility: mkToggleReviewVisibility(repos),
+});