-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nicer error message for rpc errors #5325
Conversation
Main issue is that all I have no idea when that one is triggered though. We can catch it in the line above the |
Codecov Report
@@ Coverage Diff @@
## master #5325 +/- ##
==========================================
+ Coverage 85.24% 86.65% +1.41%
==========================================
Files 99 99
Lines 6451 6454 +3
==========================================
+ Hits 5499 5593 +94
+ Misses 952 861 -91
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Oh and the way I reproduce the error is to run a gateway on a different computer in my network then try to ping it with the CLI:
Local pings to local gateways aren't able to produce the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, sometime the best solution only requires a couple of line of code !
Goals: