-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPC keep alive need a nice error message #5136
Comments
@samsja what are the steps to reproduce so i can fix this issue? |
Hey @Adesoji1 thank your for wanting to contribute ! This issue is actually not that easy to reproduce. Let me gave u some context. The keep alive mechanism is only triggered when the connection is killed abruptly between the Jina Client and the Jina Gateway (the server). In this case we just raise the raw Exception from the grpc library so the Client just end up displaying a weird message. The goal would be to catch the Exception and to display a nice message. Now starts the messy part. Simulating the abrupt kill is not easy at all ( At least I don't have a good way to do it). This mainly happened when the Flow is running in the cloud in production env. My ugly way to make it happened is to have a remote flow somewhere (on a VM on aws for example) to connect to it via my laptopt and to, ... , close my wifi. This simulate the behavior, but it is not easy to iterate. If you manage to reproduce the ugly error message you will be probably able to fix the message. Otherwise I will try to produce a simplier way of reproducing |
Is this the "ugly" error?
|
If the port rejects, you get this:
|
yes |
Context
When the keep alive mechanism is triggered we need to catch the exception and display a nice error message
The text was updated successfully, but these errors were encountered: