Exception handling #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `noexcept` where feasible * Fixed narrow numeric literals in tests, resulting in bitsery overflow * Fixed missing newline in `dispatch_gen.py`
* Moved functions/classes not in public API into `details` namespace * Moved member functions to the most private scope possible * Eliminated unnecessary/unused internal functions * Added rvalue overload to `client` functions: * `send` * `call_func` * `call_header_func_impl`
* New exception types in `exceptions` namespace * Functions will now try to fail early via exception * `void` functions can now fail * Exceptions can be serialized via a string and enum * Tests added to verify the correct exceptions are being used
jharmer95
added
enhancement
jharmer95
force-pushed
the
feature/exceptions
branch
from
af3d48f to
57dfa6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add exception handling as well as incorporate the changes made from the
cleanupbranch.This should trigger a new version (0.7.1)